test: split test-crypto-dh to avoid timeout on slow machines in the CI #49492

joyeecheung · 2023-09-04T22:15:48Z

Locally this speeds up running test-crypto-dh* from 7s to 2s. This was previously timing out in CI (took more than 2 minutes) so should see a bigger gap in the CI.

Refs: #49202
Refs: nodejs/reliability#655

joyeecheung · 2023-09-04T22:16:28Z

After splitting test-crypto-dh-generate-keys.js is the slowest test. If it still times out in the CI we need to split that further.

Locally this speeds up running test-crypto-dh* from 7s to 2s. This was previously timing out in CI (took more than 2 minutes) so should see a bigger gap in the CI.

joyeecheung · 2023-09-04T22:19:56Z

Stress test on win2012r2-vs2019 which was timing out in the CI https://ci.nodejs.org/job/node-stress-single-test/423/

joyeecheung · 2023-09-05T07:15:12Z

looks like test-crypto-dh-generate-keys.js now takes about 20s on win2012r2-vs2019, still a bit slow but well below the 2 minute timeout.

targos

RSLGTM

aduh95

RSLGTM

aduh95 · 2023-09-05T08:33:29Z

/cc @nodejs/crypto

nodejs-github-bot · 2023-09-05T08:54:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53738/

nodejs-github-bot · 2023-09-06T13:27:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53765/

nodejs-github-bot · 2023-09-07T14:43:31Z

Landed in e0fb3f7

joyeecheung · 2023-09-12T15:05:41Z

welp, test-crypto-dh-generate-keys is also timing out, so further splitting is needed..

nodejs/reliability#663

Locally this speeds up running test-crypto-dh* from 7s to 2s. This was previously timing out in CI (took more than 2 minutes) so should see a bigger gap in the CI. PR-URL: #49492 Refs: #49202 Refs: nodejs/reliability#655 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Locally this speeds up running test-crypto-dh* from 7s to 2s. This was previously timing out in CI (took more than 2 minutes) so should see a bigger gap in the CI. PR-URL: nodejs#49492 Refs: nodejs#49202 Refs: nodejs/reliability#655 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

* nodejs/node#49492 * nodejs/node#44498

Locally this speeds up running test-crypto-dh* from 7s to 2s. This was previously timing out in CI (took more than 2 minutes) so should see a bigger gap in the CI. PR-URL: #49492 Refs: #49202 Refs: nodejs/reliability#655 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

* nodejs/node#49492 * nodejs/node#44498

* chore: upgrade to Node.js v20 * src: allow embedders to override NODE_MODULE_VERSION nodejs/node#49279 * src: fix missing trailing , nodejs/node#46909 * src,tools: initialize cppgc nodejs/node#45704 * tools: allow passing absolute path of config.gypi in js2c nodejs/node#49162 * tools: port js2c.py to C++ nodejs/node#46997 * doc,lib: disambiguate the old term, NativeModule nodejs/node#45673 * chore: fixup Node.js BSSL tests * nodejs/node#49492 * nodejs/node#44498 * deps: upgrade to libuv 1.45.0 nodejs/node#48078 * deps: update V8 to 10.7 nodejs/node#44741 * test: use gcUntil() in test-v8-serialize-leak nodejs/node#49168 * module: make CJS load from ESM loader nodejs/node#47999 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * chore: address changes to CJS/ESM loading * module: make CJS load from ESM loader (nodejs/node#47999) * lib: improve esm resolve performance (nodejs/node#46652) * bootstrap: optimize modules loaded in the built-in snapshot nodejs/node#45849 * test: mark test-runner-output as flaky nodejs/node#49854 * lib: lazy-load deps in modules/run_main.js nodejs/node#45849 * url: use private properties for brand check nodejs/node#46904 * test: refactor `test-node-output-errors` nodejs/node#48992 * assert: deprecate callTracker nodejs/node#47740 * src: cast v8::Object::GetInternalField() return value to v8::Value nodejs/node#48943 * test: adapt test-v8-stats for V8 update nodejs/node#45230 * tls: ensure TLS Sockets are closed if the underlying wrap closes nodejs/node#49327 * test: deflake test-tls-socket-close nodejs/node#49575 * net: fix crash due to simultaneous close/shutdown on JS Stream Sockets nodejs/node#49400 * net: use asserts in JS Socket Stream to catch races in future nodejs/node#49400 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * src: create BaseObject with node::Realm nodejs/node#44348 * src: implement DataQueue and non-memory resident Blob nodejs/node#45258 * sea: add support for V8 bytecode-only caching nodejs/node#48191 * chore: fixup patch indices * gyp: put filenames in variables nodejs/node#46965 * build: modify js2c.py into GN executable * fix: (WIP) handle string replacement of fs -> original-fs * [v20.x] backport vm-related memory fixes nodejs/node#49874 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * src: avoid copying string in fs_permission nodejs/node#47746 * look upon my works ye mighty and dispair * chore: patch cleanup * [api] Remove AllCan Read/Write https://chromium-review.googlesource.com/c/v8/v8/+/5006387 * fix: missing include for NODE_EXTERN * chore: fixup patch indices * fix: fail properly when js2c fails in Node.js * build: fix js2c root_gen_dir * fix: lib/fs.js -> lib/original-fs.js * build: fix original-fs file xforms * fixup! module: make CJS load from ESM loader * build: get rid of CppHeap for now * build: add patch to prevent extra fs lookup on esm load * build: greatly simplify js2c modifications Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c * chore: update to handle moved internal/modules/helpers file * test: update @types/node test * feat: enable preventing cppgc heap creation * feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler * fix: no cppgc initialization in the renderer * gyp: put filenames in variables nodejs/node#46965 * test: disable single executable tests * fix: nan tests failing on node headers missing file * tls,http2: send fatal alert on ALPN mismatch nodejs/node#44031 * test: disable snapshot tests * nodejs/node#47887 * nodejs/node#49684 * nodejs/node#44193 * build: use deps/v8 for v8/tools Node.js hard depends on these in their builtins * test: fix edge snapshot stack traces nodejs/node#49659 * build: remove js2c //base dep * build: use electron_js2c_toolchain to build node_js2c * fix: don't create SafeSet outside packageResolve Fixes failure in parallel/test-require-delete-array-iterator: === release test-require-delete-array-iterator === Path: parallel/test-require-delete-array-iterator node:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^ TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22) * fix: failing crashReporter tests on Linux These were failing because our change from node::InitializeNodeWithArgs to node::InitializeOncePerProcess meant that we now inadvertently called PlatformInit, which reset signal handling. This meant that our intentional crash function ElectronBindings::Crash no longer worked and the renderer process no longer crashed when process.crash() was called. We don't want to use Node.js' default signal handling in the renderer process, so we disable it by passing kNoDefaultSignalHandling to node::InitializeOncePerProcess. * build: only create cppgc heap on non-32 bit platforms * chore: clean up util:CompileAndCall * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * fix: use thread_local BuiltinLoader * chore: fixup v8 patch indices --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>

Locally this speeds up running test-crypto-dh* from 7s to 2s. This was previously timing out in CI (took more than 2 minutes) so should see a bigger gap in the CI. PR-URL: nodejs/node#49492 Refs: nodejs/node#49202 Refs: nodejs/reliability#655 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 4, 2023

test: split test-crypto-dh to avoid timeout on slow machines in the CI

67e1053

Locally this speeds up running test-crypto-dh* from 7s to 2s. This was previously timing out in CI (took more than 2 minutes) so should see a bigger gap in the CI.

joyeecheung force-pushed the split-crypto-dh branch from 465fc5a to 67e1053 Compare September 4, 2023 22:18

targos approved these changes Sep 5, 2023

View reviewed changes

aduh95 approved these changes Sep 5, 2023

View reviewed changes

atlowChemi approved these changes Sep 5, 2023

View reviewed changes

panva approved these changes Sep 5, 2023

View reviewed changes

panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 5, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023

anonrig approved these changes Sep 5, 2023

View reviewed changes

lpinca approved these changes Sep 5, 2023

View reviewed changes

github-actions bot mentioned this pull request Sep 6, 2023

CI Reliability 2023-09-06 nodejs/reliability#657

Open

25 tasks

github-actions bot mentioned this pull request Sep 7, 2023

CI Reliability 2023-09-07 nodejs/reliability#658

Open

20 tasks

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023

nodejs-github-bot merged commit e0fb3f7 into nodejs:main Sep 7, 2023
30 checks passed

This was referenced Sep 8, 2023

CI Reliability 2023-09-08 nodejs/reliability#659

Open

CI Reliability 2023-09-09 nodejs/reliability#660

Open

ruyadorno mentioned this pull request Sep 28, 2023

v20.7.1 proposal #49917

Closed

ruyadorno mentioned this pull request Sep 28, 2023

v20.8.0 proposal #49932

Merged

codebytere added a commit to electron/electron that referenced this pull request Nov 6, 2023

chore: fixup Node.js BSSL tests

422032e

* nodejs/node#49492 * nodejs/node#44498

codebytere added a commit to electron/electron that referenced this pull request Nov 14, 2023

chore: fixup Node.js BSSL tests

703ddf9

* nodejs/node#49492 * nodejs/node#44498

codebytere added a commit to electron/electron that referenced this pull request Nov 15, 2023

chore: fixup Node.js BSSL tests

bc150a5

* nodejs/node#49492 * nodejs/node#44498

codebytere added a commit to electron/electron that referenced this pull request Nov 16, 2023

chore: fixup Node.js BSSL tests

59671c0

* nodejs/node#49492 * nodejs/node#44498

codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2023

chore: fixup Node.js BSSL tests

9ce7e8c

* nodejs/node#49492 * nodejs/node#44498

codebytere added a commit to electron/electron that referenced this pull request Nov 22, 2023

chore: fixup Node.js BSSL tests

f3b52dc

* nodejs/node#49492 * nodejs/node#44498

codebytere added a commit to electron/electron that referenced this pull request Nov 28, 2023

chore: fixup Node.js BSSL tests

927e565

* nodejs/node#49492 * nodejs/node#44498

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

codebytere added a commit to electron/electron that referenced this pull request Nov 29, 2023

chore: fixup Node.js BSSL tests

40a8636

* nodejs/node#49492 * nodejs/node#44498

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: split test-crypto-dh to avoid timeout on slow machines in the CI #49492

test: split test-crypto-dh to avoid timeout on slow machines in the CI #49492

joyeecheung commented Sep 4, 2023 •

edited

Loading

joyeecheung commented Sep 4, 2023 •

edited

Loading

joyeecheung commented Sep 4, 2023

joyeecheung commented Sep 5, 2023

targos left a comment

aduh95 left a comment

aduh95 commented Sep 5, 2023

nodejs-github-bot commented Sep 5, 2023

nodejs-github-bot commented Sep 6, 2023

nodejs-github-bot commented Sep 7, 2023

joyeecheung commented Sep 12, 2023

test: split test-crypto-dh to avoid timeout on slow machines in the CI #49492

test: split test-crypto-dh to avoid timeout on slow machines in the CI #49492

Conversation

joyeecheung commented Sep 4, 2023 • edited Loading

joyeecheung commented Sep 4, 2023 • edited Loading

joyeecheung commented Sep 4, 2023

joyeecheung commented Sep 5, 2023

targos left a comment

Choose a reason for hiding this comment

aduh95 left a comment

Choose a reason for hiding this comment

aduh95 commented Sep 5, 2023

nodejs-github-bot commented Sep 5, 2023

nodejs-github-bot commented Sep 6, 2023

nodejs-github-bot commented Sep 7, 2023

joyeecheung commented Sep 12, 2023

joyeecheung commented Sep 4, 2023 •

edited

Loading

joyeecheung commented Sep 4, 2023 •

edited

Loading