nghttp3_conv: fix call to undeclared functions 'ntohl' and 'htons' #49979

MatteoBax · 2023-09-30T12:27:16Z

I don't think it's the right method but this solves these errors when compiling for Android arm64:


../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:49:21: error: call to undeclared function 'ntohs'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    return (int64_t)ntohs(n.n16);
                    ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:53:21: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    return (int64_t)ntohl(n.n32);
                    ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:69:7: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  n = nghttp3_htonl64(n);
      ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:73:32: note: expanded from macro 'nghttp3_htonl64'
#    define nghttp3_htonl64(N) nghttp3_bswap64(N)
                               ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:60:17: note: expanded from macro 'nghttp3_bswap64'
    ((uint64_t)(ntohl((uint32_t)(N))) << 32 | ntohl((uint32_t)((N) >> 32)))
                ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:74:7: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  n = nghttp3_htonl64(n);
      ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:73:32: note: expanded from macro 'nghttp3_htonl64'
#    define nghttp3_htonl64(N) nghttp3_bswap64(N)
                               ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:60:17: note: expanded from macro 'nghttp3_bswap64'
    ((uint64_t)(ntohl((uint32_t)(N))) << 32 | ntohl((uint32_t)((N) >> 32)))
                ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:79:7: error: call to undeclared function 'htonl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  n = htonl(n);
      ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:84:7: error: call to undeclared function 'htonl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  n = htonl(n);
      ^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:89:7: error: call to undeclared function 'htons'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  n = htons(n);
      ^
7 errors generated.

I added -Wno-implicit-function-declaration option to cflags

nodejs-github-bot · 2023-09-30T12:27:20Z

Review requested:

@nodejs/gyp

mscdex · 2023-09-30T13:25:42Z

This should be unnecessary as I believe this was already fixed upstream in v0.12.0. Our copy of nghttp3 just needs to be upgraded.

bnoordhuis · 2023-09-30T19:15:51Z

That's not a proper fix, it possibly doesn't even produce a functional build. Can you try this patch?

diff --git a/deps/ngtcp2/ngtcp2.gyp b/deps/ngtcp2/ngtcp2.gyp
index a47a791610..fd6eaddb01 100644
--- a/deps/ngtcp2/ngtcp2.gyp
+++ b/deps/ngtcp2/ngtcp2.gyp
@@ -112,7 +112,7 @@
             },
           },
         }],
-        ['OS=="linux"', {
+        ['OS in "android linux"', {
           'defines': [
             'HAVE_ARPA_INET_H',
             'HAVE_NETINET_IN_H',
@@ -162,7 +162,7 @@
             },
           },
         }],
-        ['OS=="linux"', {
+        ['OS in "android linux"', {
           'defines': [
             'HAVE_ARPA_INET_H',
             'HAVE_NETINET_IN_H',

MatteoBax · 2023-09-30T21:36:27Z

That's not a proper fix, it possibly doesn't even produce a functional build. Can you try this patch?

diff --git a/deps/ngtcp2/ngtcp2.gyp b/deps/ngtcp2/ngtcp2.gyp
index a47a791610..fd6eaddb01 100644
--- a/deps/ngtcp2/ngtcp2.gyp
+++ b/deps/ngtcp2/ngtcp2.gyp
@@ -112,7 +112,7 @@
             },
           },
         }],
-        ['OS=="linux"', {
+        ['OS in "android linux"', {
           'defines': [
             'HAVE_ARPA_INET_H',
             'HAVE_NETINET_IN_H',
@@ -162,7 +162,7 @@
             },
           },
         }],
-        ['OS=="linux"', {
+        ['OS in "android linux"', {
           'defines': [
             'HAVE_ARPA_INET_H',
             'HAVE_NETINET_IN_H',

With this patch those problems no longer occur, but now the problems are:

../deps/v8/src/base/debug/stack_trace_posix.cc:156:9: error: use of undeclared identifier 'backtrace_symbols'
        backtrace_symbols(trace, static_cast<int>(size)));
        ^
  /home/matteo/Android/Sdk/ndk/26.0.10792818/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang++ -o /home/matteo/node/out/Release/obj.target/v8_libbase/deps/v8/src/base/division-by-constant.o ../deps/v8/src/base/division-by-constant.cc '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_HAS_QUIC' '-DICU_NO_USER_DATA_OVERRIDE' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_ASM' '-DV8_TARGET_ARCH_ARM64' '-DV8_HAVE_TARGET_OS' '-DV8_TARGET_OS_ANDROID' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DOBJECT_PRINT' '-DV8_INTL_SUPPORT' '-DV8_ATOMIC_OBJECT_FIELD_WRITES' '-DV8_ENABLE_LAZY_SOURCE_POSITIONS' '-DV8_USE_SIPHASH' '-DV8_SHARED_RO_HEAP' '-DV8_WIN64_UNWINDING_INFO' '-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH' '-DV8_USE_ZLIB' '-DV8_ENABLE_TURBOFAN' '-DV8_ENABLE_WEBASSEMBLY' '-DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS' '-DV8_ALLOCATION_FOLDING' '-DV8_ALLOCATION_SITE_TRACKING' '-DV8_SCRIPTORMODULE_LEGACY_LIFETIME' '-DV8_ADVANCED_BIGINT_ALGORITHMS' '-DBUILDING_V8_BASE_SHARED' '-D_GLIBCXX_USE_C99_MATH' -I../deps/v8 -I../deps/v8/include  -msign-return-address=all -Wno-unused-parameter -Wno-return-type -fno-omit-frame-pointer -fPIC -I/home/matteo/Android/Sdk/ndk/26.0.10792818/sources/android/cpufeatures -fdata-sections -ffunction-sections -O2 -fno-rtti -fno-exceptions -std=gnu++17 -MMD -MF /home/matteo/node/out/Release/.deps//home/matteo/node/out/Release/obj.target/v8_libbase/deps/v8/src/base/division-by-constant.o.d.raw   -c
../deps/v8/src/base/debug/stack_trace_posix.cc:371:32: error: use of undeclared identifier 'backtrace'; did you mean 'StackTrace'?
  count_ = static_cast<size_t>(backtrace(trace_, arraysize(trace_)));
                               ^
../deps/v8/src/base/debug/stack_trace.h:41:22: note: 'StackTrace' declared here
class V8_BASE_EXPORT StackTrace {
                     ^
2 errors generated.
make[1]: *** [tools/v8_gypfiles/v8_libbase.host.mk:186: /home/matteo/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/debug/stack_trace_posix.o] Errore 1
make[1]: *** Attesa per i processi non terminati....

bnoordhuis · 2023-09-30T21:50:35Z

Covered in #46952.

MatteoBax · 2023-09-30T22:26:08Z

Covered in #46952.

Ok. I revert the changes and applied the patch. Instead of using 'OS in "android linux"' I used 'OS=="linux" or OS=="android"' but I think it's the same thing.

This reverts commit 2070ad2. deps: fix call to undeclared functions 'ntohl' and 'htons'

nodejs-github-bot · 2023-10-01T08:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54435/

MatteoBax · 2023-10-01T12:32:19Z

What shall I do to fix failed checks?

nodejs-github-bot · 2023-10-01T12:38:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54438/

bnoordhuis · 2023-10-01T12:43:10Z

They're flaky tests. Not much you can do.

nodejs-github-bot · 2023-10-01T15:50:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54444/

nodejs-github-bot · 2023-10-02T12:44:18Z

Landed in 61411bb

This reverts commit 2070ad2. deps: fix call to undeclared functions 'ntohl' and 'htons' PR-URL: #49979 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com>

This reverts commit 2070ad2. deps: fix call to undeclared functions 'ntohl' and 'htons' PR-URL: nodejs#49979 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com>

This reverts commit 2070ad2. deps: fix call to undeclared functions 'ntohl' and 'htons' PR-URL: #49979 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com>

This reverts commit 2070ad2. deps: fix call to undeclared functions 'ntohl' and 'htons' PR-URL: nodejs#49979 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com>

This reverts commit 2070ad27a5fc674909f4bbd34e7d862c625fc54b. deps: fix call to undeclared functions 'ntohl' and 'htons' PR-URL: nodejs/node#49979 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Sep 30, 2023

MatteoBax changed the title ~~ngtcp2: fix call to undeclared function 'ntohl'~~ nghttp3_conv: fix call to undeclared functions 'ntohl' and 'htons' Sep 30, 2023

deps: fix call to undeclared functions 'ntohl' and 'htons'

b6cb6a9

This reverts commit 2070ad2. deps: fix call to undeclared functions 'ntohl' and 'htons'

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2023

bnoordhuis approved these changes Oct 1, 2023

View reviewed changes

richardlau approved these changes Oct 1, 2023

View reviewed changes

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2023

github-actions bot mentioned this pull request Oct 2, 2023

CI Reliability 2023-10-02 nodejs/reliability#681

Open

12 tasks

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2023

nodejs-github-bot merged commit 61411bb into nodejs:main Oct 2, 2023
25 checks passed

This was referenced Oct 3, 2023

CI Reliability 2023-10-03 nodejs/reliability#682

Open

CI Reliability 2023-10-04 nodejs/reliability#683

Open

RafaelGSS mentioned this pull request Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

targos mentioned this pull request Nov 12, 2023

v20.10.0 release proposal #50682

Merged

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

juanarbol mentioned this pull request Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nghttp3_conv: fix call to undeclared functions 'ntohl' and 'htons' #49979

nghttp3_conv: fix call to undeclared functions 'ntohl' and 'htons' #49979

MatteoBax commented Sep 30, 2023 •

edited

Loading

nodejs-github-bot commented Sep 30, 2023

mscdex commented Sep 30, 2023 •

edited

Loading

bnoordhuis commented Sep 30, 2023

MatteoBax commented Sep 30, 2023

bnoordhuis commented Sep 30, 2023

MatteoBax commented Sep 30, 2023

nodejs-github-bot commented Oct 1, 2023

MatteoBax commented Oct 1, 2023

nodejs-github-bot commented Oct 1, 2023

bnoordhuis commented Oct 1, 2023

nodejs-github-bot commented Oct 1, 2023

nodejs-github-bot commented Oct 2, 2023

nghttp3_conv: fix call to undeclared functions 'ntohl' and 'htons' #49979

nghttp3_conv: fix call to undeclared functions 'ntohl' and 'htons' #49979

Conversation

MatteoBax commented Sep 30, 2023 • edited Loading

nodejs-github-bot commented Sep 30, 2023

mscdex commented Sep 30, 2023 • edited Loading

bnoordhuis commented Sep 30, 2023

MatteoBax commented Sep 30, 2023

bnoordhuis commented Sep 30, 2023

MatteoBax commented Sep 30, 2023

nodejs-github-bot commented Oct 1, 2023

MatteoBax commented Oct 1, 2023

nodejs-github-bot commented Oct 1, 2023

bnoordhuis commented Oct 1, 2023

nodejs-github-bot commented Oct 1, 2023

nodejs-github-bot commented Oct 2, 2023

MatteoBax commented Sep 30, 2023 •

edited

Loading

mscdex commented Sep 30, 2023 •

edited

Loading