Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve error performance of readvSync #50100

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fs: improve error performance of readvSync #50100

merged 1 commit into from
Dec 5, 2023

Conversation

IlyasShabi
Copy link
Contributor

Local benchmark:

                                                   confidence improvement accuracy (*)    (**)   (***)
fs/bench-readvSync.js n=100000 type='invalid'             ***    123.02 %       ±1.27%  ±1.70%  ±2.24%
fs/bench-readvSync.js n=100000 type='valid'                        2.74 %       ±2.88%  ±3.84%  ±5.01%

Ref: nodejs/performance#106

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 9, 2023
anonrig
anonrig reviewed Oct 9, 2023
View reviewed changes
src/node_file.cc Outdated Show resolved Hide resolved
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54643/

@anonrig anonrig mentioned this pull request Oct 10, 2023
Open
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Open
30 tasks
@anonrig
Copy link
Member

anonrig commented Oct 13, 2023

Can you rebase and force push?

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55073/

This was referenced Oct 22, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55155/

This was referenced Oct 24, 2023
Open
Open
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56001/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit 27b2ce5 into nodejs:main Dec 5, 2023
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 27b2ce5

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@IlyasShabi @RafaelGSS
fs: improve error performance of readvSync
3f7f3ce 
PR-URL: #50100
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@IlyasShabi @richardlau
fs: improve error performance of readvSync
6764f0c 
PR-URL: #50100
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IlyasShabi @nodejs-github-bot @anonrig @aduh95 @ilyasShabiCS