doc: document non-node_modules-only runtime deprecation #50748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately.
nodejs-github-bot
added
deprecations
|
cc @nodejs/tsc |
GeoffreyBooth
approved these changes
Nov 15, 2023
tniessen
reviewed
Nov 17, 2023
I didn't even know this possibility existed. There are many modules features where we would want such a "my code only" warning. |
The reason why we had this case was because Buffer constructor was too widely used so that we had many complaints from users after emitting the warnings by default and it encouraged disabling warnings (especially for CLIs that spawn child processes). I am fairly certain that this would happen again soon, looking at our recent deprecation discussions. |
|
There is a typo in commit message. runtiem -> runtime. |
lpinca
approved these changes
Nov 18, 2023
jasnell
approved these changes
Nov 19, 2023
benjamingr
approved these changes
Nov 19, 2023
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
legendecas
reviewed
Nov 20, 2023
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
jasnell
approved these changes
Nov 25, 2023
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3ffe2e8 |
targos
pushed a commit
that referenced
this pull request
Dec 4, 2023
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately. PR-URL: #50748 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately. PR-URL: #50748 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately.