Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix backtrace with [[noreturn]] abort #50849

Merged
merged 4 commits into from
Dec 3, 2023

Commits on Nov 22, 2023

  1. src: fix backtrace with tail [[noreturn]] abort

    A function tail calls [[noreturn]] node::Abort will print an incorrect
    call stack because the frame pc was advanced when calling node::Abort
    to an invalid op, which may vary on different platforms.
    
    Dumps the backtrace in the ABORT macro instead to avoid calling
    backtrace in a tail [[noreturn]] call. Removes the [[noreturn]]
    attribute if a function calls backtrace and may be called as a tail
    statement.
    
    [[noreturn]] attribute of public functions like `napi_fatal_error` and
    `node::OnFatalError` can not be removed as compilers may complain
    about no return values after the removal.
    legendecas committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    10d80a3 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Configuration menu
    Copy the full SHA
    090a9a4 View commit details
    Browse the repository at this point in the history
  2. fixup! src: fix backtrace with [[noreturn]] abort

    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    legendecas and joyeecheung authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    536823a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3b89fba View commit details
    Browse the repository at this point in the history