Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated packages.md and added --experimental-detect-module flag #51089

Merged
merged 5 commits into from
Dec 9, 2023
Merged

Updated packages.md and added --experimental-detect-module flag #51089

merged 5 commits into from
Dec 9, 2023

Conversation

shubherthi-mitra
Copy link
Contributor

@shubherthi-mitra shubherthi-mitra commented Dec 7, 2023 •
edited by aduh95
Loading

added --experimental-detect-module flag in the docs to resolve #51057

Fixes: #51057

@shubherthi-mitra
Update packages.md
818cca5 
added --experimental-detect-module flag in the docs.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 7, 2023
@GeoffreyBooth
Copy link
Member

It feels wrong to duplicate what we have in cli.md, though it seems we’re doing the same for --input-type. Perhaps both sections should just be links to the parallel sections in cli.md, rather than repeating the content and gradually getting out of sync.

@shubherthi-mitra
Copy link
Contributor Author

It feels wrong to duplicate what we have in cli.md, though it seems we’re doing the same for --input-type. Perhaps both sections should just be links to the parallel sections in cli.md, rather than repeating the content and gradually getting out of sync.

@GeoffreyBooth I understand. But I did this after I asked here #51057 to fix the issue mentioned there. I'm new to github. My apology if any trouble caused.

@GeoffreyBooth
Copy link
Member

@shubherthi-mitra you didn’t do anything wrong, thank you for the contribution! My question was more for @nodejs/loaders, if we want to repeat the info here like you’ve done in this PR or if we’d rather do it differently, such as by just mentioning the flag’s existence and linking to its primary documentation.

@JakobJingleheimer
Copy link
Member

just mentioning the flag’s existence and linking to its primary documentation

I think this (smaller surface area to update, less chance of divergence).

@aduh95
Copy link
Contributor

aduh95 commented Dec 8, 2023

I think what we want is to modify the paragraph added in https://github.com/nodejs/node/pull/50096/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63 to add a mention of the flag (and a link to cli.md).

@shubherthi-mitra
Updated packages.md
92aad94 
Mentioned --experimental-detect-module flag and added its reference to cli.md
@shubherthi-mitra
Copy link
Contributor Author

I think what we want is to modify the paragraph added in https://github.com/nodejs/node/pull/50096/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63 to add a mention of the flag (and a link to cli.md).

I did as you have said. Please check it.

aduh95
aduh95 reviewed Dec 8, 2023
View reviewed changes
doc/api/packages.md Outdated Show resolved Hide resolved
@shubherthi-mitra
Updated packages.md (more simplified)
df062e5 
--experimental-detect-module flag and link to cli.md added.
aduh95
aduh95 reviewed Dec 8, 2023
View reviewed changes
doc/api/packages.md Outdated Show resolved Hide resolved
@shubherthi-mitra
Update packages.md added ref link
e2e556a 
Mentioned --experimental-defect-module flag in doc and added ref link to cli.md
@shubherthi-mitra
Updated packages.md fixed a paragraph
b19e147 
Simplified the paragraph under the heading ###Determining module system, mentioning --experimental-detect-module flag and reference to cli.md
JakobJingleheimer
JakobJingleheimer approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aduh95 aduh95 merged commit 37ba7a3 into nodejs:main Dec 9, 2023
12 of 13 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Dec 9, 2023

Landed in 37ba7a3, thanks for the contribution 🎉

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@shubherthi-mitra @RafaelGSS
doc: add note regarding --experimental-detect-module
637ffce 
PR-URL: #51089
Fixes: #51057
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@shubherthi-mitra @richardlau
doc: add note regarding --experimental-detect-module
6c24155 
PR-URL: #51089
Fixes: #51057
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node can't recognize static import of ES module when theres's not explicit marker
6 participants
@shubherthi-mitra @nodejs-github-bot @GeoffreyBooth @JakobJingleheimer @aduh95 @jasnell