Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update GN build files for ngtcp2 #51313

Merged
merged 1 commit into from
Jan 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions deps/ngtcp2/unofficial.gni
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ template("ngtcp2_gn_build") {
"_WINDOWS",
"HAVE_CONFIG_H",
]
} else {
defines += [
"HAVE_UNISTD_H",
]
}
if (is_linux) {
defines += [
Expand All @@ -53,16 +57,19 @@ template("ngtcp2_gn_build") {
"nghttp3/lib/"
]

sources = gypi_values.nghttp3_sources + gypi_values.ngtcp2_sources
sources = gypi_values.nghttp3_sources +
gypi_values.ngtcp2_sources +
gypi_values.ngtcp2_sources_quictls
if (node_use_openssl) {
sources += gypi_values.ngtcp2_sources_openssl
deps = [ "../openssl" ]
}

if (is_clang || !is_win) {
cflags_c = [
"-Wno-extra-semi",
"-Wno-implicit-fallthrough",
# Remove after https://github.com/ngtcp2/ngtcp2/issues/1050 is fixed.
"-Wno-sometimes-uninitialized",
]
}
}
Expand Down
Loading