doc: mark isWebAssemblyCompiledModule as eol #51442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Jan 12, 2024
richardlau
reviewed
Jan 12, 2024
Co-authored-by: Richard Lau <rlau@redhat.com>
Co-authored-by: Richard Lau <rlau@redhat.com>
benjamingr
approved these changes
Jan 12, 2024
marco-ippolito
added
the
author ready
lpinca
approved these changes
Jan 12, 2024
VoltrexKeyva
approved these changes
Jan 13, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51442 ✔ Done loading data for nodejs/node/pull/51442 ----------------------------------- PR info ------------------------------------ Title doc: mark isWebAssemblyCompiledModule as eol (#51442) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/eol-isWebAssemblyCompiledModule -> nodejs:main Labels doc, author ready Commits 3 - doc: mark isWebAssemblyCompiledModule eol - Update doc/api/deprecations.md - Update doc/api/deprecations.md Committers 2 - marco-ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/51442 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51442 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 12 Jan 2024 10:17:00 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/51442#pullrequestreview-1818730724 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51442#pullrequestreview-1818964796 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/51442#pullrequestreview-1819705315 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ee5cfcb5f7..9fce1df548 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - a5c4c2fa40 doc: add links in `offboarding.md` - 9fce1df548 doc: add links in `offboarding.md` -------------------------------------------------------------------------------- HEAD is now at 9fce1df548 doc: add links in `offboarding.md` ✔ Reset to origin/main - Downloading patch for 51442 From https://github.com/nodejs/node * branch refs/pull/51442/merge -> FETCH_HEAD ✔ Fetched commits as 9fce1df54850..ccd0dd616fa4 -------------------------------------------------------------------------------- [main 238f3b8897] doc: mark isWebAssemblyCompiledModule eol Author: marco-ippolito Date: Fri Jan 12 11:10:32 2024 +0100 2 files changed, 5 insertions(+), 23 deletions(-) [main 8f2dbcf5d6] Update doc/api/deprecations.md Author: Marco Ippolito Date: Fri Jan 12 14:37:12 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 1a3a8dc6fb] Update doc/api/deprecations.md Author: Marco Ippolito Date: Fri Jan 12 14:37:27 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/7518569308 |
marco-ippolito
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7496bc4 |
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51442 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51442 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51442 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51442 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
isWebAssemblyCompiledModulehas actually already been removed from the codebase with this commit.I just updated documentation and marked it as EOL since the code isn't there anymore and it could not be runtime deprecated.
Although eol deprecations are semver major, I would not mark it as such because its only a documentation update.