Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use checkIfCollectableByCounting in SourceTextModule leak test #51512

Merged
merged 1 commit into from
Jan 22, 2024
Merged

test: use checkIfCollectableByCounting in SourceTextModule leak test #51512

merged 1 commit into from
Jan 22, 2024

Conversation

joyeecheung
Copy link
Member

...which may be more reliable than than checkIfCollectable().

Refs: #51362

@joyeecheung
test: use checkIfCollectableByCounting in SourceTextModule leak test
1aea2e6 
...which may be more reliable than than checkIfCollectable().
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 18, 2024
@targos
Copy link
Member

targos commented Jan 18, 2024

Should I try to apply it to #51362 for validation?

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56848/

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56859/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56867/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit aef9d4e into nodejs:main Jan 22, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in aef9d4e

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
@joyeecheung @marco-ippolito
test: use checkIfCollectableByCounting in SourceTextModule leak test
89c1321 
...which may be more reliable than than checkIfCollectable().

PR-URL: nodejs#51512
Refs: nodejs#51362
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@joyeecheung @targos
test: use checkIfCollectableByCounting in SourceTextModule leak test
c88f0b6 
...which may be more reliable than than checkIfCollectable().

PR-URL: #51512
Refs: #51362
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@joyeecheung @marco-ippolito
test: use checkIfCollectableByCounting in SourceTextModule leak test
c1bdba6 
...which may be more reliable than than checkIfCollectable().

PR-URL: nodejs#51512
Refs: nodejs#51362
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@joyeecheung @richardlau
test: use checkIfCollectableByCounting in SourceTextModule leak test
1c03ce7 
...which may be more reliable than than checkIfCollectable().

PR-URL: #51512
Refs: #51362
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@joyeecheung @richardlau
test: use checkIfCollectableByCounting in SourceTextModule leak test
1d8e65a 
...which may be more reliable than than checkIfCollectable().

PR-URL: #51512
Refs: #51362
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joyeecheung @targos @nodejs-github-bot @lpinca @aduh95 @debadree25