From bf8c5ef7d95c2e47d6de8aca6a6ef4959caa3ce4 Mon Sep 17 00:00:00 2001 From: duncanchiu409 Date: Tue, 16 Jan 2024 17:49:11 +1030 Subject: [PATCH 01/10] doc: update family = 0 in dns.md --- doc/api/dns.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index b0ff62c2cd5d1b..a9e4b824f8a5c6 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -204,8 +204,8 @@ changes: * `options` {integer | Object} * `family` {integer|string} The record family. Must be `4`, `6`, or `0`. For backward compatibility reasons,`'IPv4'` and `'IPv6'` are interpreted as `4` - and `6` respectively. The value `0` indicates that IPv4 and IPv6 addresses - are both returned. **Default:** `0`. + and `6` respectively. The value `0` indicates that either IPv4 or IPv6 address + is returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple flags may be passed by bitwise `OR`ing their values. * `all` {boolean} When `true`, the callback returns all resolved addresses in From baf8942af78b420fbe8ea39cf67b0ce87944fcdf Mon Sep 17 00:00:00 2001 From: duncanchiu409 Date: Fri, 19 Jan 2024 09:43:20 +1030 Subject: [PATCH 02/10] doc: update dns.lookup details The family option and all option have wrong description. Fixes: https://github.com/nodejs/node/issues/51482 --- doc/api/dns.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index a9e4b824f8a5c6..f4e08a7df1fccc 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -204,8 +204,9 @@ changes: * `options` {integer | Object} * `family` {integer|string} The record family. Must be `4`, `6`, or `0`. For backward compatibility reasons,`'IPv4'` and `'IPv6'` are interpreted as `4` - and `6` respectively. The value `0` indicates that either IPv4 or IPv6 address - is returned. **Default:** `0`. + and `6` respectively. The value `0` indicates that either IPv4 or IPv6 + address is returned. Noted if value `0` is used with `{family: true}`, + both IPv4 and IPv6 addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple flags may be passed by bitwise `OR`ing their values. * `all` {boolean} When `true`, the callback returns all resolved addresses in @@ -953,8 +954,9 @@ added: v10.6.0 * `hostname` {string} * `options` {integer | Object} * `family` {integer} The record family. Must be `4`, `6`, or `0`. The value - `0` indicates that IPv4 and IPv6 addresses are both returned. **Default:** - `0`. + `0` indicates that either IPv4 or IPv6 address is returned. Noted if + value `0` used with `{family: true}`, both IPv4 and IPv6 addresses + are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple flags may be passed by bitwise `OR`ing their values. * `all` {boolean} When `true`, the `Promise` is resolved with all addresses in From c6dc46910a41dbb84bd5769cc1de75c6041f3647 Mon Sep 17 00:00:00 2001 From: duncanchiu409 Date: Fri, 19 Jan 2024 10:03:01 +1030 Subject: [PATCH 03/10] doc: fix typo --- doc/api/dns.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index f4e08a7df1fccc..8d7be8a753e561 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -205,7 +205,7 @@ changes: * `family` {integer|string} The record family. Must be `4`, `6`, or `0`. For backward compatibility reasons,`'IPv4'` and `'IPv6'` are interpreted as `4` and `6` respectively. The value `0` indicates that either IPv4 or IPv6 - address is returned. Noted if value `0` is used with `{family: true}`, + address is returned. Noted if value `0` is used with `{ all: true }`, both IPv4 and IPv6 addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple flags may be passed by bitwise `OR`ing their values. @@ -955,7 +955,7 @@ added: v10.6.0 * `options` {integer | Object} * `family` {integer} The record family. Must be `4`, `6`, or `0`. The value `0` indicates that either IPv4 or IPv6 address is returned. Noted if - value `0` used with `{family: true}`, both IPv4 and IPv6 addresses + value `0` used with `{ all: true }`, both IPv4 and IPv6 addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple flags may be passed by bitwise `OR`ing their values. From fa948173b44adc006021d50303bacbb7700aa4d6 Mon Sep 17 00:00:00 2001 From: Duncan Chiu <64763059+duncanchiu409@users.noreply.github.com> Date: Fri, 26 Jan 2024 14:18:40 +1030 Subject: [PATCH 04/10] Update doc/api/dns.md Co-authored-by: Paolo Insogna --- doc/api/dns.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index 8d7be8a753e561..aa4b738fc26984 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -204,7 +204,7 @@ changes: * `options` {integer | Object} * `family` {integer|string} The record family. Must be `4`, `6`, or `0`. For backward compatibility reasons,`'IPv4'` and `'IPv6'` are interpreted as `4` - and `6` respectively. The value `0` indicates that either IPv4 or IPv6 + and `6` respectively. The value `0` indicates that either a IPv4 or IPv6 address is returned. Noted if value `0` is used with `{ all: true }`, both IPv4 and IPv6 addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple From 6c1e119b784f4743064b4ff8a7932e40d0ac0999 Mon Sep 17 00:00:00 2001 From: Duncan Chiu <64763059+duncanchiu409@users.noreply.github.com> Date: Fri, 26 Jan 2024 14:18:59 +1030 Subject: [PATCH 05/10] Update doc/api/dns.md Co-authored-by: Paolo Insogna --- doc/api/dns.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index aa4b738fc26984..7153dc58426b19 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -954,7 +954,9 @@ added: v10.6.0 * `hostname` {string} * `options` {integer | Object} * `family` {integer} The record family. Must be `4`, `6`, or `0`. The value - `0` indicates that either IPv4 or IPv6 address is returned. Noted if + `0` indicates that either a IPv4 or IPv6 address is returned. If + value `0` used with `{ all: true }` (see below), both IPv4 and IPv6 addresses + are returned. **Default:** `0`. value `0` used with `{ all: true }`, both IPv4 and IPv6 addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple From 03da199afefea458119fe79f24ad1c1e7e62ed5a Mon Sep 17 00:00:00 2001 From: Duncan Chiu <64763059+duncanchiu409@users.noreply.github.com> Date: Fri, 26 Jan 2024 14:19:17 +1030 Subject: [PATCH 06/10] Update doc/api/dns.md Co-authored-by: Paolo Insogna --- doc/api/dns.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index 7153dc58426b19..88feb7e61852bd 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -205,7 +205,7 @@ changes: * `family` {integer|string} The record family. Must be `4`, `6`, or `0`. For backward compatibility reasons,`'IPv4'` and `'IPv6'` are interpreted as `4` and `6` respectively. The value `0` indicates that either a IPv4 or IPv6 - address is returned. Noted if value `0` is used with `{ all: true }`, + address is returned. If the value `0` is used with `{ all: true } (see below)`, both IPv4 and IPv6 addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple flags may be passed by bitwise `OR`ing their values. From 78af021b8f196c0f59263157ee6c461aadca2642 Mon Sep 17 00:00:00 2001 From: Duncan Chiu <64763059+duncanchiu409@users.noreply.github.com> Date: Sat, 27 Jan 2024 15:28:40 +1030 Subject: [PATCH 07/10] Update doc/api/dns.md Co-authored-by: Paolo Insogna --- doc/api/dns.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index 88feb7e61852bd..041eb113909e9f 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -954,7 +954,7 @@ added: v10.6.0 * `hostname` {string} * `options` {integer | Object} * `family` {integer} The record family. Must be `4`, `6`, or `0`. The value - `0` indicates that either a IPv4 or IPv6 address is returned. If + `0` indicates that either an IPv4 or IPv6 address is returned. If value `0` used with `{ all: true }` (see below), both IPv4 and IPv6 addresses are returned. **Default:** `0`. value `0` used with `{ all: true }`, both IPv4 and IPv6 addresses From a1951a56c679289fb33b7f7eaedfbfd7cfddeafa Mon Sep 17 00:00:00 2001 From: Duncan Chiu <64763059+duncanchiu409@users.noreply.github.com> Date: Sat, 27 Jan 2024 15:28:54 +1030 Subject: [PATCH 08/10] Update doc/api/dns.md Co-authored-by: Paolo Insogna --- doc/api/dns.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index 041eb113909e9f..4e97b537df8d64 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -204,7 +204,7 @@ changes: * `options` {integer | Object} * `family` {integer|string} The record family. Must be `4`, `6`, or `0`. For backward compatibility reasons,`'IPv4'` and `'IPv6'` are interpreted as `4` - and `6` respectively. The value `0` indicates that either a IPv4 or IPv6 + and `6` respectively. The value `0` indicates that either an IPv4 or IPv6 address is returned. If the value `0` is used with `{ all: true } (see below)`, both IPv4 and IPv6 addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple From 6eeae0f3305028bb28705168bf4b2774d3ac1deb Mon Sep 17 00:00:00 2001 From: Duncan Chiu <64763059+duncanchiu409@users.noreply.github.com> Date: Sun, 28 Jan 2024 09:43:27 +1030 Subject: [PATCH 09/10] Update dns.md Co-authored-by: Luigi Pinca --- doc/api/dns.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index 4e97b537df8d64..df748fdd8ab00f 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -954,10 +954,8 @@ added: v10.6.0 * `hostname` {string} * `options` {integer | Object} * `family` {integer} The record family. Must be `4`, `6`, or `0`. The value - `0` indicates that either an IPv4 or IPv6 address is returned. If - value `0` used with `{ all: true }` (see below), both IPv4 and IPv6 addresses - are returned. **Default:** `0`. - value `0` used with `{ all: true }`, both IPv4 and IPv6 addresses + `0` indicates that either an IPv4 or IPv6 address is returned. If the + value `0` is used with `{ all: true }` (see below), both IPv4 and IPv6 addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple flags may be passed by bitwise `OR`ing their values. From 39726ed097cf3f3b8c5aba6362136d4896ff0793 Mon Sep 17 00:00:00 2001 From: Duncan Chiu <64763059+duncanchiu409@users.noreply.github.com> Date: Mon, 29 Jan 2024 23:01:04 +0000 Subject: [PATCH 10/10] fix: lint pipeline --- doc/api/dns.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index df748fdd8ab00f..00a109937448bf 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -955,8 +955,8 @@ added: v10.6.0 * `options` {integer | Object} * `family` {integer} The record family. Must be `4`, `6`, or `0`. The value `0` indicates that either an IPv4 or IPv6 address is returned. If the - value `0` is used with `{ all: true }` (see below), both IPv4 and IPv6 addresses - are returned. **Default:** `0`. + value `0` is used with `{ all: true }` (see below), both IPv4 and IPv6 + addresses are returned. **Default:** `0`. * `hints` {number} One or more [supported `getaddrinfo` flags][]. Multiple flags may be passed by bitwise `OR`ing their values. * `all` {boolean} When `true`, the `Promise` is resolved with all addresses in