Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update c-ares to 1.26.0 for Android #51646

Conversation

MeowShe
Copy link
Contributor

@MeowShe MeowShe commented Feb 2, 2024

Related PR: #51582

Update ares_config.h for Android with c-ares version 1.26.0.

NOTICE: This is only for arch arm64-v8a.

Built with Android NDK 26.1.10909125, c-ares HEAD.

Related PR: nodejs#51582

Update ares_config.h for Android with c-ares version 1.26.0.

NOTICE: This is only for arch arm64-v8a.

Built with `Android NDK 26.1.10909125`, c-ares `HEAD`.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Feb 2, 2024
@MeowShe
Copy link
Contributor Author

MeowShe commented Feb 2, 2024

cc: @lpinca I just opened a new PR.

@lpinca
Copy link
Member

lpinca commented Feb 2, 2024

Is it possible to use Autotools to create ares_config.h? I'm asking because it would make the diff smaller.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca merged commit 433b11b into nodejs:actions/tools-update-c-ares Feb 2, 2024
59 checks passed
@MeowShe MeowShe deleted the actions/tools-update-c-ares branch February 3, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants