-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: implement build android workflow #51666
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
67b0286
to
0b50161
Compare
0b50161
to
d718af7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other files use the extension .yml
as far as I can tell. I'd suggest renaming to build-androi.yml
for consistency.
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
You're right, it's a mistake. |
|
|
I know it shouldn't, but I'm afraid it will (it runs on |
GitHub unfortunately still does not support allowed failures (see actions/runner#2347), but perhaps one could use |
We can use |
The main purpose of this pull request is to advance the official support of Node.js for the Android platform. Once the goal is achieved and it becomes stable, this check should become mandatory. |
Perhaps in the short term having it be a path-based Action? Would allow a smaller number of PRs that have it as a check as a way to warm up to having it on all PRs. |
Maybe label is a better idea? We label PRs when if it fit to run Android build test. |
I guess there doesn't seem to be a clear definition of paths, we don't know what paths are available to run Android build tests in particular. |
Experimental activation of CI Workflow for building on the Android platform.