Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: only build the ESM facade for builtins when they are needed #51669

Closed
wants to merge 2 commits into from

Commits on Feb 5, 2024

  1. lib: only build the ESM facade for builtins when they are needed

    We previously build the ESM facade (synthetic modules re-exporting
    builtin's exports) for builtins even when they are not directly
    import'ed (which rarely happens for internal builtins as that
    requires --expose-internals). This patch removes
    the eager generation to avoid the overhead and the extra
    promises created in facade building when it's not reqested by the user.
    When the facade is needed the ESM loader that can be requested
    it in the translator on-demand.
    
    Drive-by: set the ModuleWrap prototype to null in the built-in
    snapshot.
    joyeecheung committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    2be93a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. benchmark: rename startup.js to startup-core.js

    It is easier to filter the core startup benchmark with this name.
    joyeecheung committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    397aadb View commit details
    Browse the repository at this point in the history