Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: extract sourceMappingURL from module #51690

Closed
wants to merge 7 commits into from
Closed

lib,src: extract sourceMappingURL from module #51690

wants to merge 7 commits into from

Conversation

unbyte
Copy link
Contributor

@unbyte unbyte commented Feb 7, 2024

Node.js used regex to extract sourceMappingURL from the source code
of ESM files. This method led to inaccuracies, notably the erroneous
extraction of url from strings. This change attempts to retrieving the
correct url from V8 for ESM files.

Refs: #51522

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Feb 7, 2024
aduh95
aduh95 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass, left a few nits

test/fixtures/source-map/extract-url/cjs-url-in-middle.js Outdated Show resolved Hide resolved
test/fixtures/source-map/extract-url/cjs-url-in-string.js Outdated Show resolved Hide resolved
test/fixtures/source-map/extract-url/esm-url-in-middle.mjs Outdated Show resolved Hide resolved
test/fixtures/source-map/extract-url/esm-url-in-string.mjs Outdated Show resolved Hide resolved
@unbyte unbyte requested a review from aduh95 February 7, 2024 15:30
joyeecheung
joyeecheung reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we extract the sourceURL using the V8 API as well?

@unbyte
Copy link
Contributor Author

unbyte commented Feb 7, 2024

@joyeecheung

Shouldn't we extract the sourceURL using the V8 API as well?

This is what I want to do. In fact I initiated this PR after identifying several issues with the source map support in Node.js, notably:

  1. Node.js utilizes regex to extract sourceURLs in all files and sourceMappingURLs in ESM files,
  2. Node.js requires the eval-ed code text to include both sourceURL and sourceMappingURL for stack trace rewriting.

This PR specifically addresses the handling of sourceMappingURL without delving into sourceURL-related changes. This limitation is intentional to keep the scope manageable for my first contribution to Node.js.

Moving forward, I'm going to resolve the identified issues, including the extraction of sourceURL.

@joyeecheung
Copy link
Member

joyeecheung commented Feb 7, 2024 •
edited
Loading

I think it's okay to leave the source URL for a follow-up. Can you leave a TODO/FIXME comment for them?

@unbyte
Copy link
Contributor Author

unbyte commented Feb 7, 2024

@joyeecheung
Of course! Done.

@legendecas legendecas added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 8, 2024
legendecas
legendecas approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

Note for who lands this PR: please amend the commit message with the PR title as the message of the first commit was not aligned with it.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57082/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57331/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57336/

@legendecas legendecas added the source maps Issues and PRs related to source map support. label Feb 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57423/

legendecas pushed a commit that referenced this pull request Feb 26, 2024
@unbyte @legendecas
lib,src: extract sourceMappingURL from module
fc0f2cf 
PR-URL: #51690
Refs: #51522
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@legendecas
Copy link
Member

Landed in fc0f2cf

@legendecas legendecas closed this Feb 26, 2024
@legendecas legendecas mentioned this pull request Feb 26, 2024
Closed
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@unbyte @marco-ippolito
lib,src: extract sourceMappingURL from module
fb45da7 
PR-URL: #51690
Refs: #51522
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@unbyte @marco-ippolito
lib,src: extract sourceMappingURL from module
e905e99 
PR-URL: #51690
Refs: #51522
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
@unbyte @marco-ippolito
lib,src: extract sourceMappingURL from module
8dc3f91 
PR-URL: #51690
Refs: #51522
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
@huming2207 huming2207 mentioned this pull request Mar 15, 2024
Closed
6 tasks
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@unbyte @richardlau
lib,src: extract sourceMappingURL from module
007bc5b 
PR-URL: #51690
Refs: #51522
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@unbyte @richardlau
lib,src: extract sourceMappingURL from module
861e040 
PR-URL: #51690
Refs: #51522
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@unbyte @rdw-msft
lib,src: extract sourceMappingURL from module
082d3ac 
PR-URL: nodejs#51690
Refs: nodejs#51522
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. source maps Issues and PRs related to source map support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@unbyte @nodejs-github-bot @joyeecheung @legendecas @aduh95