From 847748d69c65d9e3015e99c0882e9ded59e3984d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Wed, 7 Feb 2024 14:02:15 +0000 Subject: [PATCH] tools: disable automated libuv updates Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. --- .github/workflows/tools.yml | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml index 50481a26822cb4..225b7b107ef39e 100644 --- a/.github/workflows/tools.yml +++ b/.github/workflows/tools.yml @@ -27,7 +27,7 @@ on: - googletest - histogram - icu - - libuv + # - libuv - lint-md-dependencies - llhttp - minimatch @@ -174,14 +174,17 @@ jobs: cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output - - id: libuv - subsystem: deps - label: dependencies - run: | - ./tools/dep_updaters/update-libuv.sh > temp-output - cat temp-output - tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true - rm temp-output + # libuv update was disabled because of Feb 14, 2024 security releas + # modified the bundled version of libuv, we cannot automatically update + # libuv without potentially undoing those changes. + # - id: libuv + # subsystem: deps + # label: dependencies + # run: | + # ./tools/dep_updaters/update-libuv.sh > temp-output + # cat temp-output + # tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true + # rm temp-output - id: lint-md-dependencies subsystem: tools label: tools