From aae45256bb665053761daa6f0e7fb17a58ce761f Mon Sep 17 00:00:00 2001 From: Cong Zhang <13283869+congzhangzh@users.noreply.github.com> Date: Fri, 22 Mar 2024 01:23:00 +0800 Subject: [PATCH 1/3] doc: add tips about vcpkg cause build faild on windows --- BUILDING.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/BUILDING.md b/BUILDING.md index 53f636a4cf641e..38888cb8eb7379 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -578,6 +578,16 @@ to run it again before invoking `make -j4`. ### Windows +#### Tips +You may need disable vcpkg integration if you got link error about symbol redefine related to zlib.lib(zlib1.dll), even you never install it by hand, as vcpkg is part of CLion and Visual Studio now. + +```bat +REM find your vcpkg +vcpkg integration remove +``` + +Refs: #24448, https://github.com/microsoft/vcpkg/issues/37518, [vcpkg](https://github.com/microsoft/vcpkg/) + #### Prerequisites ##### Option 1: Manual install From 0895d7c3213ba5da3479255d2f1e91e97a9320ca Mon Sep 17 00:00:00 2001 From: Cong Zhang <13283869+congzhangzh@users.noreply.github.com> Date: Sat, 23 Mar 2024 14:39:24 +0000 Subject: [PATCH 2/3] doc: fix for lint-md --- BUILDING.md | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 38888cb8eb7379..4d7a172c085de1 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -579,14 +579,20 @@ to run it again before invoking `make -j4`. ### Windows #### Tips -You may need disable vcpkg integration if you got link error about symbol redefine related to zlib.lib(zlib1.dll), even you never install it by hand, as vcpkg is part of CLion and Visual Studio now. -```bat -REM find your vcpkg +You may need disable vcpkg integration if you got link error about symbol +redefine related to zlib.lib(zlib1.dll), even you never install it by hand, +as vcpkg is part of CLion and Visual Studio now. + +```powershell +# find your vcpkg +# double check vcpkg install the related file +vcpkg owns zlib.lib +vcpkg owns zlib1.dll vcpkg integration remove ``` -Refs: #24448, https://github.com/microsoft/vcpkg/issues/37518, [vcpkg](https://github.com/microsoft/vcpkg/) +Refs: #24448, , [vcpkg](https://github.com/microsoft/vcpkg/) #### Prerequisites From 896a5fae685bf68eeb06434044aee0ce6eb5ee92 Mon Sep 17 00:00:00 2001 From: Cong Zhang <13283869+congzhangzh@users.noreply.github.com> Date: Sat, 30 Mar 2024 07:43:10 +0800 Subject: [PATCH 3/3] doc: Update BUILDING.md Co-authored-by: Stefan Stojanovic --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 4d7a172c085de1..61a1df6377c54b 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -589,7 +589,7 @@ as vcpkg is part of CLion and Visual Studio now. # double check vcpkg install the related file vcpkg owns zlib.lib vcpkg owns zlib1.dll -vcpkg integration remove +vcpkg integrate remove ``` Refs: #24448, , [vcpkg](https://github.com/microsoft/vcpkg/)