Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove unused imports from worker_threads.md #54147

Merged
merged 1 commit into from
Jul 31, 2024
Merged

doc: remove unused imports from worker_threads.md #54147

merged 1 commit into from
Jul 31, 2024

Conversation

debbs061
Copy link
Contributor

@debbs061 debbs061 commented Jul 31, 2024 •
edited
Loading

Remove unused imports from worker_threads.md.

  • Removed once import from node:events as it was not used in the code.
  • Removed isMainThread import from node:worker_threads as it was not used in the code.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jul 31, 2024
@aduh95 aduh95 changed the title typings: remove unused imports from worker_threads.md doc: remove unused imports from worker_threads.md Jul 31, 2024
deokjinkim
deokjinkim approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@deokjinkim deokjinkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debbs061 Thank you for contribution. Could you change subsystem from typings to doc in commit title? You can force push with -f option.

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7941b4b into nodejs:main Jul 31, 2024
16 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7941b4b

targos pushed a commit that referenced this pull request Aug 14, 2024
@debbs061 @targos
doc: remove unused imports from worker_threads.md
af99ba3 
PR-URL: #54147
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@debbs061 @nodejs-github-bot @lpinca @deokjinkim @aduh95 @targos