Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove module-based permission doc #54266

Merged
merged 1 commit into from
Aug 10, 2024
Merged

doc: remove module-based permission doc #54266

merged 1 commit into from
Aug 10, 2024

Conversation

RafaelGSS
Copy link
Member

Follow up #52583

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 8, 2024
@RedYetiDev RedYetiDev added policy Issues and PRs related to the policy subsystem. permission Issues and PRs related to the Permission Model labels Aug 8, 2024
@RafaelGSS RafaelGSS removed the permission Issues and PRs related to the Permission Model label Aug 8, 2024
@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2024
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit d708281 into nodejs:main Aug 10, 2024
29 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d708281

targos pushed a commit that referenced this pull request Aug 14, 2024
@RafaelGSS @targos
doc: remove module-based permission doc
db62da7 
PR-URL: #54266
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Aug 14, 2024
@RafaelGSS @targos
doc: remove module-based permission doc
26c37f7 
PR-URL: #54266
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@trivikr trivikr trivikr approved these changes

@aymen94 aymen94 aymen94 approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. policy Issues and PRs related to the policy subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RafaelGSS @nodejs-github-bot @lpinca @anonrig @aymen94 @trivikr @marco-ippolito @targos @RedYetiDev