process: add process.features.require_module

[joyeecheung]

For detecting whether require(esm) is supported without triggering the experimental warning.

[nodejs-github-bot]

Review requested:

• @nodejs/loaders
• @nodejs/startup

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (bbdfeeb) to head (1609e78).
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55241      +/-   ##
==========================================
- Coverage   88.41%   88.41%   -0.01%     
==========================================
  Files         652      652              
  Lines      186612   186615       +3     
  Branches    36062    36061       -1     
==========================================
+ Hits       165001   165003       +2     
+ Misses      14885    14879       -6     
- Partials     6726     6733       +7     

Files with missing lines	Coverage Δ
lib/internal/bootstrap/node.js	99.78% <100.00%> (+<0.01%)	⬆️

... and 34 files with indirect coverage changes

[mcollina]

lgtm

[richardlau]

test-process-features will need an update:

https://github.com/nodejs/node/actions/runs/11147823375/job/30983051322?pr=55241#step:7:6106

=== release test-process-features ===
Path: parallel/test-process-features
Error: --- stderr ---
node:assert:90
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected ... Lines skipped

+ Set(10) {
- Set(9) {
    'cached_builtins',
    'debug',
    'inspector',
    'ipv6',
+   'require_module',
    'tls',
...
    'tls_sni',
    'uv'
  }
    at Object.<anonymous> (/home/runner/work/node/node/test/parallel/test-process-features.js:8:8)
    at Module._compile (node:internal/modules/cjs/loader:1560:14)
    at Object..js (node:internal/modules/cjs/loader:1703:10)
    at Module.load (node:internal/modules/cjs/loader:1328:32)
    at Function._load (node:internal/modules/cjs/loader:1138:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)
    at node:internal/main/run_main_module:36:49 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: Set(10) {
    'inspector',
    'debug',
    'uv',
    'ipv6',
    'tls_alpn',
    'tls_sni',
    'tls_ocsp',
    'tls',
    'cached_builtins',
    'require_module'
  },
  expected: Set(9) {
    'inspector',
    'debug',
    'uv',
    'ipv6',
    'tls_alpn',
    'tls_sni',
    'tls_ocsp',
    'tls',
    'cached_builtins'
  },
  operator: 'deepStrictEqual'
}

Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-process-features.js

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62917/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62931/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62932/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62934/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62936/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62965/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62968/

[joyeecheung]

@aduh95 @mcollina @richardlau CI is green - can I get some re-approvals to help it make it into v23?

As for #55241 (comment) - I don't think the request to repeat the documentation with a false condition is blocking. Feel free to open a follow-up PR if you feel the addition is necessary. @aduh95

[nodejs-github-bot]

Landed in b0f0252