test: add buffer to fs_permission tests #55734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
RedYetiDev
added
permission
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55734 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 654 654
Lines 187655 187655
Branches 36111 36112 +1
=======================================
+ Hits 165889 165896 +7
- Misses 14996 14997 +1
+ Partials 6770 6762 -8 |
jasnell
reviewed
Nov 6, 2024
| @@ -21,6 +21,11 @@ const regularFile = __filename; | |||
| permission: 'FileSystemRead', | |||
| resource: path.toNamespacedPath(blockedFile), | |||
| })); | |||
| fs.readFile(bufferBlockedFile, common.expectsError({ | |||
There was a problem hiding this comment.
non-blocking nit... this particular test is rather dense. While we're in here making changes it would be nice to fixup the formatting just a bit so that it's easier to read and see what is going on. Comments explaining what is being tested would be helpful also.
jasnell
approved these changes
Nov 6, 2024
aduh95
approved these changes
Nov 6, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c8e1298 |
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2024
PR-URL: #55734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the permission model coverage by including Buffer in fs tests.