Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add test-reporters #55757

Merged
merged 1 commit into from
Nov 16, 2024
Merged

benchmark: add test-reporters #55757

merged 1 commit into from
Nov 16, 2024

Conversation

RedYetiDev
Copy link
Member

Refs: #55723

This PR benchmarks the reporters currently included in the node:test/reporters module.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. test_runner Issues and PRs related to the test runner subsystem. labels Nov 7, 2024
@RedYetiDev RedYetiDev mentioned this pull request Nov 7, 2024
Open
31 tasks
@RedYetiDev
Copy link
Member Author

CC @nodejs/test_runner

@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2024
@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 14, 2024
@RedYetiDev
Copy link
Member Author

Doesn't look like the CI started, I've re added the label

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63550/

H4ad
H4ad approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on benchmarks!

@RedYetiDev
Copy link
Member Author

Can someone resume the CI please? Thanks!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63561/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63564/

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7d28de9 into nodejs:main Nov 16, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7d28de9

aduh95 pushed a commit that referenced this pull request Nov 16, 2024
@RedYetiDev @aduh95
benchmark: add test-reporters
32e5bbc 
PR-URL: #55757
Refs: #55723
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 19, 2024
Merged
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@RedYetiDev @tpoisseau
benchmark: add test-reporters
9dcdd5c 
PR-URL: nodejs#55757
Refs: nodejs#55723
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarchini pmarchini pmarchini approved these changes

@rluvaton rluvaton rluvaton approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RedYetiDev @nodejs-github-bot @H4ad @rluvaton @pmarchini