doc: clarify triager role #55775

gireeshpunathil · 2024-11-08T10:38:21Z

highlight additional points around triager role

nodejs-github-bot · 2024-11-08T10:38:26Z

Review requested:

@nodejs/tsc

legendecas · 2024-11-08T10:50:13Z

doc/contributing/issues.md

@@ -60,5 +60,12 @@ activities, such as applying labels and closing/reopening/assigning issues.
 For more information on the roles and permissions, see ["Permission levels for
 repositories owned by an organization"](https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization).

+triagers are requested to abstain from below actions:
+* approve or request changes to a pull request


I don't think it is appropriate to ask triagers abstain from request changes to a pull request. Any contributors are welcomed to give reviews on a pull request. It's just that only collaborators can effectively block a pull request from landing (but a clear reason is still required anyway).

My feeling is that given the additional permissions as a triager, a triager should be sticking to the project standard, like the guide for collaborators:

Welcoming first-time contributors/issue posters

Where this is unclear, leave the issue or pull request open for several days to allow for discussion.

Most importantly, be friendly.

GH docs shows two different actions separately:

submit reviews on PRs

approve or request change to PRs

while anyone is free to review PRs, approval and request change is better reserved to committers, lest it can confuse contributors (especially new comers)?

I can see how that'd be true for folks who have write permission on the repo but are not collaborators. I'm not sure I understand how that'd apply to triaggers. For triaggers who are collaborators: why would we be asking them to refrain? For triaggers who not collaborators: why would it different from other non-collaborator contributors?

I think the clarification should focus on the new priviledges granted with the role and responsibility of the role. Like in the collaborator guide, the new priviledges are "writing to the repo". And in terms of the triager role, it is "managing the issues".

"Request a change" is not a new priviledge granted as a triger. Anyone, non-collaborators, can request change with the GitHub UI. And GitHub UI distinguishes effectiveness of a change request with red icons or grey icons.

that is where the problem I guess. you both raise valid points. however when looking from the author point of view, they could get confused when a request change coming from a triager and perceive it as different (and more enforcing) than that from a normal contributor, while in reality its the same. how do we tell a triager to not pretend they have additional privilege while reviewing a PR?

triagers do not have permission to do those

I'm not sure I agree, anyone can submit a review, approve or request changes. Anyway, I think we do not agree on whether the difference in GH UI is enough to avoid confusion, and we'll have to agree to disagree.

and we'll have to agree to disagree.

agree.

anyone can submit a review, approve or request changes.

is it an opinion, endorsed process, or a best practice? in any case pls show me a documented evidence of this being the case - as this to me is a deviation from github defined roles and permissions.

if anyone can request changes, what is your recommendation to authors of PRs when a non-collaborator does so? are they bound to address it?

By "anyone can submit a review, approve or request changes.", I was meaning "it is a feature that GitHub offers", I didn't mean that anyone can block a PR from landing.

are they bound to address it?

IMO yes, ideally all comments should be addressed (which doesn't not mean they have to take the suggestion, e.g. adding a comment saying "Thanks for the suggestion, I prefer not to take it" would be a way to address it)

given that we agreed to disagree on whether an author will be misled by a triager action on PRs and whether GH UI color code is sufficient to disambiguate that confusion or not, I will yield and go ahead with what we have consensus on.

thanks @aduh95 !

(ofc, the other topic: whether anyone can use all PR review actions or not - has wider scope, and just for triagers, and doesn't need to be sorted out here)

doc/contributing/issues.md

RedYetiDev · 2024-11-08T11:13:04Z

doc/contributing/issues.md

@@ -60,5 +60,12 @@ activities, such as applying labels and closing/reopening/assigning issues.
 For more information on the roles and permissions, see ["Permission levels for
 repositories owned by an organization"](https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization).

+triagers are requested to abstain from below actions:


Suggested change

triagers are requested to abstain from below actions:

Triagers should refrain from the following actions:

RedYetiDev · 2024-11-08T11:15:46Z

doc/contributing/issues.md

+* approve or request changes to a pull request
+* edit wikis
+
+triagers are requested to apply caution while performing below actions:


Suggested change

triagers are requested to apply caution while performing below actions:

Triagers should apply caution when performing the following actions:

RedYetiDev · 2024-11-08T11:16:08Z

doc/contributing/issues.md

+* edit wikis
+
+triagers are requested to apply caution while performing below actions:
+* close or assign issues or prs


Suggested change

* close or assign issues or prs

* Closing and/or assigning issues or PRs.

RedYetiDev · 2024-11-08T11:50:08Z

doc/contributing/issues.md

+* Show no patience towards spam or troll, close the issue without interacting with it and
+  report the user to the moderation repository.
+* If you're not able to reproduce an issue, leave a comment asking for more info and
+  add the `needs more info` label.


This label doesn't exist

We should create it +1

It can probably replace repro exists as an inverse.

RedYetiDev · 2024-11-08T11:50:27Z

doc/contributing/issues.md

+When triagging issues and PR:
+
+* Show patience and empathy, especially to first-time contributors.
+* Show no patience towards spam or troll, close the issue without interacting with it and


Suggested change

* Show no patience towards spam or troll, close the issue without interacting with it and

* Show no patience towards spam or trolls, close the issue/PR without interacting with it and

RedYetiDev · 2024-11-08T11:51:13Z

doc/contributing/issues.md

@@ -60,5 +60,21 @@ activities, such as applying labels and closing/reopening/assigning issues.
 For more information on the roles and permissions, see ["Permission levels for
 repositories owned by an organization"](https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization).

+triagers are requested to abstain from below actions:
+* approve or request changes to a pull request


Suggested change

* approve or request changes to a pull request

* Approving or requesting changes to a pull request.

highlight additional points around triager role Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot · 2024-11-10T22:15:14Z

Landed in e542686

highlight additional points around triager role Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #55775 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

highlight additional points around triager role Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#55775 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 8, 2024

legendecas requested changes Nov 8, 2024

View reviewed changes

aduh95 reviewed Nov 8, 2024

View reviewed changes

doc/contributing/issues.md Outdated Show resolved Hide resolved

RedYetiDev reviewed Nov 8, 2024

View reviewed changes

RedYetiDev added the meta Issues and PRs related to the general management of the project. label Nov 8, 2024

RedYetiDev reviewed Nov 8, 2024

View reviewed changes

doc: clarify triager role

319353d

highlight additional points around triager role Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

gireeshpunathil force-pushed the triager-role-hardening branch from e68e0fb to 319353d Compare November 9, 2024 06:25

aduh95 approved these changes Nov 9, 2024

View reviewed changes

UlisesGascon approved these changes Nov 9, 2024

View reviewed changes

legendecas approved these changes Nov 10, 2024

View reviewed changes

RafaelGSS approved these changes Nov 10, 2024

View reviewed changes

MoLow approved these changes Nov 10, 2024

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 10, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2024

nodejs-github-bot merged commit e542686 into nodejs:main Nov 10, 2024
21 checks passed

RafaelGSS mentioned this pull request Nov 19, 2024

2024-11-20, Version 23.3.0 (Current), @RafaelGSS #55921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: clarify triager role #55775

doc: clarify triager role #55775

gireeshpunathil commented Nov 8, 2024

nodejs-github-bot commented Nov 8, 2024

legendecas Nov 8, 2024

gireeshpunathil Nov 8, 2024

aduh95 Nov 8, 2024

legendecas Nov 8, 2024

gireeshpunathil Nov 8, 2024

aduh95 Nov 8, 2024

gireeshpunathil Nov 8, 2024

aduh95 Nov 8, 2024 •

edited

Loading

gireeshpunathil Nov 9, 2024

gireeshpunathil Nov 9, 2024

RedYetiDev Nov 8, 2024 •

edited

Loading

RedYetiDev Nov 8, 2024

RedYetiDev Nov 8, 2024

RedYetiDev Nov 8, 2024

marco-ippolito Nov 8, 2024 •

edited

Loading

RedYetiDev Nov 8, 2024

RedYetiDev Nov 8, 2024

RedYetiDev Nov 8, 2024

nodejs-github-bot commented Nov 10, 2024

	triagers are requested to abstain from below actions:
	Triagers should refrain from the following actions:

	triagers are requested to apply caution while performing below actions:
	Triagers should apply caution when performing the following actions:

	* close or assign issues or prs
	* Closing and/or assigning issues or PRs.

	* Show no patience towards spam or troll, close the issue without interacting with it and
	* Show no patience towards spam or trolls, close the issue/PR without interacting with it and

	* approve or request changes to a pull request
	* Approving or requesting changes to a pull request.

doc: clarify triager role #55775

doc: clarify triager role #55775

Conversation

gireeshpunathil commented Nov 8, 2024

nodejs-github-bot commented Nov 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aduh95 Nov 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RedYetiDev Nov 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marco-ippolito Nov 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 10, 2024

aduh95 Nov 8, 2024 •

edited

Loading

RedYetiDev Nov 8, 2024 •

edited

Loading

marco-ippolito Nov 8, 2024 •

edited

Loading