From df2fe33b6ea1446a8ef53a36f8bbf7d58b0ef7e3 Mon Sep 17 00:00:00 2001 From: hirabhullar Date: Thu, 1 Dec 2016 09:01:51 -0800 Subject: [PATCH 1/2] test: refactor test-child-fork-exec-path.js Changed equal to strictEqual --- test/parallel/test-child-process-fork-exec-path.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-child-process-fork-exec-path.js b/test/parallel/test-child-process-fork-exec-path.js index e42b72f2b85886..e2f7e4b4d20eef 100644 --- a/test/parallel/test-child-process-fork-exec-path.js +++ b/test/parallel/test-child-process-fork-exec-path.js @@ -9,7 +9,7 @@ var copyPath = path.join(common.tmpDir, 'node-copy.exe'); if (process.env.FORK) { assert(process.send); - assert.equal(process.argv[0], copyPath); + assert.strictEqual(process.argv[0], copyPath); process.send(msg); process.exit(); } else { @@ -34,6 +34,6 @@ if (process.env.FORK) { })); child.on('exit', common.mustCall(function(code) { fs.unlinkSync(copyPath); - assert.equal(code, 0); + assert.strictEqual(code, 0); })); } From 94e8940210c36eb56ba3bd2baebd26c07c8af9f0 Mon Sep 17 00:00:00 2001 From: hirabhullar Date: Thu, 1 Dec 2016 09:34:21 -0800 Subject: [PATCH 2/2] test: refactor test-fs-write.js Changed var to const and equal to strictEqual --- test/parallel/test-fs-write.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js index 766cb0b2cea1d2..9960a91a4f7515 100644 --- a/test/parallel/test-fs-write.js +++ b/test/parallel/test-fs-write.js @@ -1,13 +1,13 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); -var path = require('path'); -var Buffer = require('buffer').Buffer; -var fs = require('fs'); -var fn = path.join(common.tmpDir, 'write.txt'); -var fn2 = path.join(common.tmpDir, 'write2.txt'); -var expected = 'ümlaut.'; -var constants = fs.constants; +const common = require('../common'); +const assert = require('assert'); +const path = require('path'); +const Buffer = require('buffer').Buffer; +const fs = require('fs'); +const fn = path.join(common.tmpDir, 'write.txt'); +const fn2 = path.join(common.tmpDir, 'write2.txt'); +const expected = 'ümlaut.'; +const constants = fs.constants; common.refreshTmpDir(); @@ -15,12 +15,12 @@ fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) { if (err) throw err; console.log('open done'); fs.write(fd, '', 0, 'utf8', function(err, written) { - assert.equal(0, written); + assert.strictEqual(0, written); }); fs.write(fd, expected, 0, 'utf8', common.mustCall(function(err, written) { console.log('write done'); if (err) throw err; - assert.equal(Buffer.byteLength(expected), written); + assert.strictEqual(Buffer.byteLength(expected), written); fs.closeSync(fd); const found = fs.readFileSync(fn, 'utf8'); console.log('expected: "%s"', expected); @@ -36,12 +36,12 @@ fs.open(fn2, constants.O_CREAT | constants.O_WRONLY | constants.O_TRUNC, 0o644, if (err) throw err; console.log('open done'); fs.write(fd, '', 0, 'utf8', (err, written) => { - assert.equal(0, written); + assert.strictEqual(0, written); }); fs.write(fd, expected, 0, 'utf8', common.mustCall((err, written) => { console.log('write done'); if (err) throw err; - assert.equal(Buffer.byteLength(expected), written); + assert.strictEqual(Buffer.byteLength(expected), written); fs.closeSync(fd); const found = fs.readFileSync(fn2, 'utf8'); console.log('expected: "%s"', expected);