Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for V8 vulnerabilities? #152

Open
richardlau opened this issue Aug 29, 2023 · 2 comments
Open

Check for V8 vulnerabilities? #152

richardlau opened this issue Aug 29, 2023 · 2 comments

Comments

@richardlau
Copy link
Member

Semi-related to #151, I noticed that we do not currently scan for V8 vulnerabilities in this repo:

# TODO: Add V8
# "V8": Dependency("cpe:2.3:a:google:chrome:*:*:*:*:*:*:*:*", "v8"),

@RafaelGSS
Copy link
Member

I think we've decided to not open V8 vulnerabilities because, currently, we don't have anyone to ask and assess if it affects Node.js. Could you confirm @mhdawson?

@mhdawson
Copy link
Member

mhdawson commented Sep 1, 2023

@RafaelGSS I don't think I remember that. I think we want to know about any public CVEs in advance versus having people report them to us like in #151.

My only guess is there was some technical reason why it was not working. I think we should try again and see if it reports properly. From the commented out line I'm not sure if checking all versions of chrome makes sense though. Maybe the issue was that we'd need to map the version of V8 in Node.js back to a version in Chrome to get sensible reports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants