-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc-eventLoop #1573
Comments
i think this is clear |
/cc @evanlucas |
@zzuligy But then where will you put the retrieval of I/O events? |
I think the confusion comes from another part of the doc being wrong. In the Phases Overview section, the I/O Callbacks bullet states:
However, in the Phases Detail > I/O Callbacks section, the detail states:
Unless I'm misunderstanding something, it's the poll phase that "executes almost all callbacks with the exception of close callbacks, the ones scheduled by timers, and setImmediate()". This seems to be confirmed in the libuv doc on the I/O loop which says this regarding the poll phase (#8 in the doc):
Perhaps the Node.js doc should change the phase names to be more in sync with the libuv doc.
So the Phases Overview would look more like this:
|
@dmcghan Sounds good, would you mind creating a PR for it? |
@dmcghan in |
@fhemberger Sure, will do. @amandeepmittal I don't think so. |
I created PR #1603. I simplified "pending I/O callbacks" to "pending callbacks" and left the name of the "poll" phase alone since it was referred to in other places. |
the event loop graph is in the top down order,which make me confuse the poll phase.
if say poll phase like a moniter,which kick off the cycyle, loop and execute the callback in the phase may be most clear。
The text was updated successfully, but these errors were encountered: