Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Node 12.16.3 release post didn't go live #3143

Closed
cjihrig opened this issue Apr 28, 2020 · 4 comments
Closed

The Node 12.16.3 release post didn't go live #3143

cjihrig opened this issue Apr 28, 2020 · 4 comments

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Apr 28, 2020

  • URL: missing
  • Browser version: All
  • Operating system: All

It looks like the 12.16.3 release blog post (nodejs/node#33009) never got published to the site.

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 28, 2020

cc: @nodejs/build

@nschonni
Copy link
Member

Someone with access might need to restart the hooks nodejs/build#2123 (comment) or it's the delay in the CDN purge #3129 (comment)

@rvagg
Copy link
Member

rvagg commented Apr 29, 2020

I can't actually fully explain this, everything seems to be running properly on our end.

I ran it manually on the sever (build-site.sh) but it said that the HEAD commit was the HEAD-1 commit (9b23caa) and built from that.

Here's a tail of a grep of 'HEAD is now at' from github-webhook.log that shows something similar:

stderr: HEAD is now at 9b4c4a4... build(deps): bump sass from 1.26.3 to 1.26.5
stdout: HEAD is now at 9b4c4a4 build(deps): bump sass from 1.26.3 to 1.26.5
stderr: HEAD is now at 9b4c4a4... build(deps): bump sass from 1.26.3 to 1.26.5
stdout: HEAD is now at 9b4c4a4 build(deps): bump sass from 1.26.3 to 1.26.5
stderr: HEAD is now at 7095061... [PT-BR]: translate about resources to pt-br (#3125)
stdout: HEAD is now at 7095061 [PT-BR]: translate about resources to pt-br (#3125)
stderr: HEAD is now at 7095061... [PT-BR]: translate about resources to pt-br (#3125)
stdout: HEAD is now at 7095061 [PT-BR]: translate about resources to pt-br (#3125)
stderr: HEAD is now at f9939e0... build(deps): bump fibers from 4.0.2 to 5.0.0 (#3134)
stdout: HEAD is now at f9939e0 build(deps): bump fibers from 4.0.2 to 5.0.0 (#3134)
stderr: HEAD is now at f9939e0... build(deps): bump fibers from 4.0.2 to 5.0.0 (#3134)
stdout: HEAD is now at f9939e0 build(deps): bump fibers from 4.0.2 to 5.0.0 (#3134)
stderr: HEAD is now at 9b23caa... build(deps-dev): bump chokidar from 3.3.1 to 3.4.0 (#3140)
stdout: HEAD is now at 9b23caa build(deps-dev): bump chokidar from 3.3.1 to 3.4.0 (#3140)
stderr: HEAD is now at 9b23caa... build(deps-dev): bump chokidar from 3.3.1 to 3.4.0 (#3140)

I've run it a second time and it's picked up the proper HEAD now.

The script does a full reset and fetch to get the latest HEAD: https://github.com/nodejs/build/blob/master/ansible/www-standalone/resources/scripts/build-site.sh#L32-L35

git reset --hard
git clean -fdx
git fetch origin
git checkout origin/master

so I'm lost beyond that, perhaps GitHub is having a problem?

It's live now: https://nodejs.org/en/blog/release/v12.16.3/

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 29, 2020

Thanks Rod. I'll close this issue. If anyone wants to reopen it for some type of postmortem, feel free.

@cjihrig cjihrig closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants