Nodejs download page is acting weird

[zhaoqiu-china]

Version

No response

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

1. go to https://nodejs.org/en/download/
2. click "Current"
3. click Windows Installer. (My pc os is win10-x64 and "Windows Installer" has a href linkd "https://nodejs.org/dist/v19.7.0/node-v19.7.0-x64.msi")
4. I expect that x64.msi will be downloaded, however it's x86.msi

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

Additional information

No response

[SEWeiTung]

Not only for Current，But LTS as well has the issue in the download page
Link to x64 but download for x86....

[SEWeiTung]

The reason may be the "x86" is fixed in the download link....And it is dynamically changed by js behind. However due to some reason it changes but in fact it isn't....I'll investigate why and fix the bug

[ovflowd]

@MaledongGit, your PR does not fix the issue. The issue is actually about the OS detection we have. We cannot reliably detect if the Windows OS is x64 or x86, and that's what needs to be fixed.

[ovflowd]

The actual PR fixing this issue is #5025

[ovflowd]

The reason may be the "x86" is fixed in the download link....And it is dynamically changed by js behind. However due to some reason it changes but in fact it isn't....I'll investigate why and fix the bug

It is changing it, just changing it incorrectly. We assess the platform architecture by looking up the user agent and some meta info. In some browsers, we don't assess that reliably.

@zhaoqiu-china, on your screenshot, the Error attached in the console has nothing to do with the download issue. It is just the behaviour of next/link trying to prefetch that URL; I will change that component not to use next/link :)

[ovflowd]

For reference: This is fixed by #5025 and #5106

[ovflowd]

@SpeedyCodeYT, what are you even talking about? 😅

[SEWeiTung]

The reason may be the "x86" is fixed in the download link....And it is dynamically changed by js behind. However due to some reason it changes but in fact it isn't....I'll investigate why and fix the bug

It is changing it, just changing it incorrectly. We assess the platform architecture by looking up the user agent and some meta info. In some browsers, we don't assess that reliably.

@zhaoqiu-china, on your screenshot, the Error attached in the console has nothing to do with the download issue. It is just the behaviour of next/link trying to prefetch that URL; I will change that component not to use next/link :)

Got it, I found it later.
Thanks for your guidance and I've removed my PR here.

[ovflowd]

@MaledongGit no worries! I appreciate your help and intentions. I hope my explanations on your PR made sense ;)

[SEWeiTung]

Hi @zhaoqiu-china：

This bug should be fixed now, could you please check and close the issue?

[zhaoqiu-china]

Hi @zhaoqiu-china：

This bug should be fixed now, could you please check and close the issue?

Ok, thanks for your efforts!