From f945bb5c56d35cb49c1a0e37a3cb00f66a5020e3 Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Wed, 10 Apr 2024 21:39:59 +0300 Subject: [PATCH] remove CPUSET due to a it not working as we see a lot of NaN in the results (#161) --- benchmarks/community-benchmark/run.sh | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/benchmarks/community-benchmark/run.sh b/benchmarks/community-benchmark/run.sh index 032a813..2866c18 100644 --- a/benchmarks/community-benchmark/run.sh +++ b/benchmarks/community-benchmark/run.sh @@ -38,7 +38,6 @@ echo "The following are optional across both use cases" echo "RUNS = defaults to empty" echo "FILTER = defaults to empty" echo "MACHINE_THREADS - used for building node. Defaults to all threads on machine" -echo "CPUSET - used for pinning to specific CPU cores. Default to 0-11 (performance cores)" } if [ -z $PULL_ID ]; then @@ -54,7 +53,6 @@ fi mandatory CATEGORY optional RUNS optional FILTER -optional CPUSET "0-11" getMACHINE_THREADS=`cat /proc/cpuinfo |grep processor|tail -n1|awk {'print $3'}` let getMACHINE_THREADS=getMACHINE_THREADS+1 #getting threads this way is 0 based. Add one optional MACHINE_THREADS $getMACHINE_THREADS @@ -98,14 +96,11 @@ fi if [ -n "$RUNS" ]; then RUNS="--runs ${RUNS}" fi -if [ -n "$CPUSET" ]; then - CPUSET="--set CPUSET=${CPUSET}" -fi # run benchmark fileName=output`date +%d%m%y-%H%M%S`.csv echo "Output will be saved to $fileName" pwd -./node-master benchmark/compare.js $CPUSET --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName +./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName cat $fileName | Rscript benchmark/compare.R mv $fileName $startDir