Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undici websocket #114

Open
KhafraDev opened this issue Sep 18, 2023 · 5 comments
Open

undici websocket #114

KhafraDev opened this issue Sep 18, 2023 · 5 comments

Comments

@KhafraDev
Copy link
Member

undici's WebSocket hasn't been benchmarked and there is probably a lot of room for improvements

https://github.com/nodejs/undici/tree/main/lib/websocket
@metcoder95
Copy link
Member

Do you have the benchmark results?
I kinda remember seeing them somewhere but do know where

@KhafraDev
Copy link
Member Author

I've never benchmarked it

@metcoder95
Copy link
Member

Do you have a suggestion of how to benchmark it? Otherwise I'll try to find a way and share it 🙂

@KhafraDev
Copy link
Member Author

I'd adjust ws' benchmarks https://github.com/websockets/ws/tree/master/bench

@KhafraDev KhafraDev mentioned this issue Sep 23, 2023
Merged
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this issue Nov 7, 2023
benchmark: add undici websocket benchmark
f2cc56d 
Refs: nodejs/performance#114
@Ch3nYuY Ch3nYuY mentioned this issue Nov 7, 2023
Merged
@Ch3nYuY
Copy link

Ch3nYuY commented Nov 7, 2023

nodejs/node#50586
I added a simple undici benchmark based on https://github.com/websockets/ws/blob/master/bench/speed.js

nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Dec 6, 2023
benchmark: add undici websocket benchmark
212a972 
Refs: nodejs/performance#114
PR-URL: #50586
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Dec 15, 2023
@RafaelGSS
benchmark: add undici websocket benchmark
38fd0ca 
Refs: nodejs/performance#114
PR-URL: #50586
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
richardlau pushed a commit to nodejs/node that referenced this issue Mar 25, 2024
@richardlau
benchmark: add undici websocket benchmark
443d4fc 
Refs: nodejs/performance#114
PR-URL: #50586
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metcoder95 @KhafraDev @Ch3nYuY