Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLibuvNow is slow #49

Closed
ronag opened this issue Feb 4, 2023 · 5 comments · Fixed by nodejs/node#46579
Closed

getLibuvNow is slow #49

ronag opened this issue Feb 4, 2023 · 5 comments · Fixed by nodejs/node#46579
Assignees
@joyeecheung

Comments

@ronag
Copy link
Member

ronag commented Feb 4, 2023 •
edited
Loading

Screenshot 2023-02-03 at 20 32 40

Affects timers performance. I think it could be optimised with v8 fast calls. Profile is from undici.
@ronag ronag changed the title GetLibuvNow is slow getLibuvNow is slow Feb 4, 2023
@tony-go
Copy link
Member

tony-go commented Feb 4, 2023

It will be the moment to test the documentation shipped by @anonrig 🤩

@anonrig
Copy link
Member

anonrig commented Feb 8, 2023

How can we get the environment from a fast API? Referencing:

  Environment* env = Environment::GetCurrent(args);

@anonrig anonrig mentioned this issue Feb 9, 2023
Merged
@mhdawson mhdawson mentioned this issue Feb 15, 2023
Closed
@ronag
Copy link
Member Author

ronag commented Feb 20, 2023

nodejs/node#46579

@anonrig
Copy link
Member

anonrig commented Feb 20, 2023

Keeping this issue as it is, until @joyeecheung's pull request is merged.

@anonrig
Copy link
Member

anonrig commented Apr 3, 2023

We can close this issue, since the PR is merged.

@anonrig anonrig closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joyeecheung joyeecheung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

timers: use V8 fast API calls joyeecheung/node
4 participants
@anonrig @ronag @joyeecheung @tony-go