-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.6.1 breaks ES5 compatibility #507
Comments
Indeed. Either that or the support section needs an update… Line 27 in 24b22f6
|
Sorry about this, it was definitely not the goal. Could you send me a small script to validate that I don't break it again? |
hi, you can use es-check to check your lib can be use by es5. |
@ningyougan @kanongil @MonsieurLanza could you verify if #508 fixes it? |
I change your new commit pkg in node_modules ,but oops This dependency was not found:
* abort-controller in ./node_modules/browserify-sign/node_modules/readable-stream/lib/internal/streams/pipeline.js, ./node_modules/hash-base/node_modules/readable-stream/lib/internal/streams/pipeline.js
To install it, you can run: npm install --save abort-controller I compare #508 with 3.6.1 ,it's a new external dep. Is Thx for your congtribution! Maybe this bug is my bad, plz help me to confirm the question. |
@ningyougan you would need to run this in an environment that has either a global |
Our ES5 build breaks when
readable-stream
gets updated to 3.6.1.This commit precisely introduces ES6 syntax, such as
const
keywords, class methods shorthands…fec7fe9
I am aware that ES5 is a somewhat old thing, however, in my understanding, an EcmaScript version bump should not occur in a patch version.
The text was updated successfully, but these errors were encountered: