CI Reliability 2022-09-09 #372
Comments
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this issue
Sep 13, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this issue
Sep 15, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: nodejs#44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this issue
Sep 26, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this issue
Sep 26, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this issue
Sep 26, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol
pushed a commit
to nodejs/node
that referenced
this issue
Oct 4, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol
pushed a commit
to nodejs/node
that referenced
this issue
Oct 4, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol
pushed a commit
to nodejs/node
that referenced
this issue
Oct 4, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol
pushed a commit
to nodejs/node
that referenced
this issue
Oct 7, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol
pushed a commit
to nodejs/node
that referenced
this issue
Oct 10, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol
pushed a commit
to nodejs/node
that referenced
this issue
Oct 11, 2022
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: #44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this issue
Jan 3, 2023
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: nodejs/node#44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this issue
Jan 3, 2023
Instead of removing the callback before generating heap snapshot and then adding it back after the heap snapshot is generated, just remove it once the heap snapshot limit is reached. Otherwise if the worker callback kicks in and sets the heap limit to higher value during the heap snapshot generation, the current_heap_limit in the heap snapshot callback becomes invalid, and we might return a heap limit lower than the current one, resulting in OOM. In addition add more logs and checks in Worker::NearHeapLimit() to help us catch problems. PR-URL: nodejs/node#44581 Refs: nodejs/reliability#372 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Failures in node-test-pull-request/46396 to node-test-pull-request/46494 that failed more than 2 PRs
(Generated with
ncu-ci walk pr --stats=true --markdown /home/runner/work/reliability/reliability/results.md)JSTest Failure
parallel/test-watch-modeExample
parallel/test-bootstrap-modulesExample
parallel/test-heapsnapshot-near-heap-limit-workerExample
report/test-report-fatalerror-oomerror-not-setExample
report/test-report-fatalerror-oomerror-setExample
wpt/test-webcryptoExample
Jenkins Failure
Backing channel 'JNLP4-connect connection from ... is disconnected.Example
Build timed out (after 15 minutes). Marking the build as failed.Example
Build Failure
ERROR: Build step failed with exceptionExample
dtrace: failed to compile script src/v8ustack.d: Preprocessor failed to process input programExample
error: remote GitHub already exists.Example
ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?Example
Error: module '_bootlocale' has no attribute 'getpreferredencoding'Example
Git Failure
Progress
parallel/test-watch-mode(5)parallel/test-bootstrap-modules(4)parallel/test-heapsnapshot-near-heap-limit-worker(3)report/test-report-fatalerror-oomerror-not-set(2)report/test-report-fatalerror-oomerror-set(2)wpt/test-webcrypto(2)Backing channel 'JNLP4-connect connection from ... is disconnected.(7)Build timed out (after 15 minutes). Marking the build as failed.(2)ERROR: Build step failed with exception(6)dtrace: failed to compile script src/v8ustack.d: Preprocessor failed to process input program(4)error: remote GitHub already exists.(3)ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?(2)Error: module '_bootlocale' has no attribute 'getpreferredencoding'(2)The text was updated successfully, but these errors were encountered: