Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a test to guarantee open() syscalls #827

Closed
RafaelGSS opened this issue Aug 26, 2022 · 4 comments
Closed

Include a test to guarantee open() syscalls #827

RafaelGSS opened this issue Aug 26, 2022 · 4 comments

Comments

@RafaelGSS
Copy link
Member

In the #799 issue, we are adding a statement that we trust on every opened file that's documented. To make this statement stronger, might make sense to include a test using eBPF for Linux (not sure about other platforms) that will guarantee the list of opened files, thus making the dependencies update slightly smooth.

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Nov 25, 2022
@RafaelGSS RafaelGSS removed the stale label Nov 25, 2022
@mhdawson
Copy link
Member

I think the idea of a test validating that we only open expected files is a good one. Maybe that should be one of the things we include in the initiatives for this year?

@RafaelGSS
Copy link
Member Author

Sure, I was working on it. I had to stop due to other priorities.

@RafaelGSS
Copy link
Member Author

Just opened nodejs/node#46150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants