Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol from proxy url is ignored when building proxy Agent #2390

Closed
cheenamalhotra opened this issue Oct 31, 2023 · 2 comments
Closed

Protocol from proxy url is ignored when building proxy Agent #2390

cheenamalhotra opened this issue Oct 31, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cheenamalhotra
Copy link

Bug Description

Imagine proxy URL in format:
http://123.123.1.1:8080

Code here:

undici/lib/proxy-agent.js

Line 33 in 3a77cbb

protocol: opts.protocol || 'https'

Doesn't respect 'http' protocol if specified in proxy Url.

Environment

Node 18
@cheenamalhotra cheenamalhotra added the bug Something isn't working label Oct 31, 2023
@metcoder95
Copy link
Member

It somehow relates to #2278, would be better if we fully support the URL object instead

@rossilor95 rossilor95 mentioned this issue Feb 22, 2024
Merged
7 tasks
@metcoder95
Copy link
Member

Closed by #2810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metcoder95 @cheenamalhotra