Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPT Tests, which timeout should be shown as failure #2627

Closed
Uzlopak opened this issue Jan 19, 2024 · 4 comments
Closed

WPT Tests, which timeout should be shown as failure #2627

Uzlopak opened this issue Jan 19, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Jan 19, 2024

If a test times out it will only be logged

undici/test/wpt/runner/runner.mjs

Line 232 in b82c490

console.log(`${test} timed out after ${timeout}ms`)

Imho the test case should be marked as failed.
@Uzlopak Uzlopak added the enhancement New feature or request label Jan 19, 2024
@KhafraDev KhafraDev added the good first issue Good for newcomers label Jan 22, 2024
@rossilor95
Copy link
Contributor

Hi! Can I work on this issue?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 24, 2024

I guess so. There is afaik a no cookie licking policy.

@rossilor95 rossilor95 mentioned this issue Jan 26, 2024
Merged
7 tasks
@merojosa
Copy link
Contributor

@metcoder95 @KhafraDev FYI, this issue should be closed

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 26, 2024

Thanks for the hint. ;)

@Uzlopak Uzlopak closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Uzlopak @merojosa @KhafraDev @rossilor95