Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose MessageEvent for node core #2769

Closed
KhafraDev opened this issue Feb 16, 2024 · 2 comments · Fixed by #2770
Closed

expose MessageEvent for node core #2769

KhafraDev opened this issue Feb 16, 2024 · 2 comments · Fixed by #2770
Labels
enhancement New feature or request

Comments

@KhafraDev
Copy link
Member

Both node and undici implement MessageEvent. Node's implementation is far from spec compliant, whereas undici's is (we run idl WPTs on MessageEvent). Should we replace the existing MessageEvent with undici's?

On a side note: since I had no idea that node had MessageEvent, it does not work with WebSocket.
@KhafraDev KhafraDev added the enhancement New feature or request label Feb 16, 2024
@metcoder95
Copy link
Member

It will most likely mean a major, should we aim for v22?
I'm just not fully aware what's the process on Node.js releases for that 😅

@KhafraDev
Copy link
Member Author

Unfortunately error messages do change, but all tests from node core pass.

@KhafraDev KhafraDev mentioned this issue Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expose MessageEvent in fetch bundle KhafraDev/undici
2 participants
@metcoder95 @KhafraDev