-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce package size by compressing wasm base64 first via brotli? #2870
Comments
Do you have any numbers? Just run it through brotli. |
compression would trade startup time with disk space, and that's usually a bad trade. |
What problem are we trying to solve exactly? |
If my assessment is right, than llhttp simd wasm shrinks from 55kb to 14kb. Thus base64 encoded wasm changes from 74kb to about 18kb. If #2871 removes normal wasm, than we speak of about a sofe of about 50 kb, if the PR does not pass and we still ship both wasm files, we speak a save of 100 kb. |
Doesn't npm compress the package anyway? |
We pack undici into node. So node gets bigger. |
Isn't node also compressed? |
idk. but even if compression doesnt mean a reduction to 0. ;) |
I mean you get pretty much the same compression if you compress it before the bundle or compress it with the bundle... |
I think we could save some bytes by compressing the base64 encoded wasm before the base64 encoding via brotli.
The text was updated successfully, but these errors were encountered: