Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition of fetch missing from types #953

Closed
runeh opened this issue Aug 13, 2021 · 1 comment · Fixed by #997
Closed

Definition of fetch missing from types #953

runeh opened this issue Aug 13, 2021 · 1 comment · Fixed by #997
Labels
enhancement New feature or request fetch good first issue Good for newcomers Status: help-wanted This issue/pr is open for contributions
Milestone
fetch

Comments

@runeh
Copy link
Contributor

runeh commented Aug 13, 2021

The fetch implementation ( #928 ) does not include pdated typescript types. So it's not possible to import fetch without getting errors when using typescript.
@runeh runeh added the enhancement New feature or request label Aug 13, 2021
@ronag ronag added the fetch label Aug 13, 2021
@ronag
Copy link
Member

ronag commented Aug 13, 2021

PR welcome!

@ronag ronag added the Status: help-wanted This issue/pr is open for contributions label Aug 13, 2021
@ronag ronag added this to the stable fetch milestone Aug 13, 2021
@mcollina mcollina added the good first issue Good for newcomers label Aug 13, 2021
@wojpawlik wojpawlik mentioned this issue Aug 24, 2021
Merged
6 tasks
ronag pushed a commit that referenced this issue Aug 25, 2021
@wojpawlik
feat: fetch types (#997)
5425b77 
fixes #953
KhafraDev pushed a commit to KhafraDev/undici that referenced this issue Jun 23, 2022
@wojpawlik @KhafraDev
feat: fetch types (nodejs#997)
cf279c8 
fixes nodejs#953
crysmags pushed a commit to crysmags/undici that referenced this issue Feb 27, 2024
@wojpawlik @crysmags
feat: fetch types (nodejs#997)
b5925cc 
fixes nodejs#953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fetch good first issue Good for newcomers Status: help-wanted This issue/pr is open for contributions
Projects
None yet
Milestone
fetch
Development

Successfully merging a pull request may close this issue.

feat: fetch types
3 participants
@mcollina @runeh @ronag