fix: implement fetch per spec #928

ronag · 2021-08-05T06:28:39Z

No description provided.

mcollina

The node-fetch copyright should be retained somewhere.

ronag · 2021-08-05T07:46:57Z

The node-fetch copyright should be retained somewhere.

#928 (comment)

Any suggestion of how to best do that?

ronag · 2021-08-05T07:51:44Z

How about 8c198e1?

mcollina · 2021-08-05T07:57:29Z

ok for me.

index.js

test/node-fetch/response.js

test/node-fetch/headers.js

test/node-fetch/main.js

lib/api/api-fetch/headers.js

ronag · 2021-08-05T11:07:49Z

Applied the file restructure/refactor to main and rebased to make it more clear what changes this PR does.

GrosSacASac · 2021-08-12T17:34:30Z

Does it mean fetch will be built in to nodejs ?

jasnell · 2021-08-12T17:40:11Z

Not yet. nodejs/undici is still a separate module independent of node.js core. There is an active discussion happening about whether it will be vendored in but that decision has not been made yet.

szmarczak · 2021-08-12T18:02:17Z

Just finished reviewing this. This is really good piece of art :)

max-hk · 2021-08-12T20:23:36Z

Not yet. nodejs/undici is still a separate module independent of node.js core. There is an active discussion happening about whether it will be vendored in but that decision has not been made yet.

Where do the discussion take place?

trivikr · 2021-08-12T21:15:16Z

Not yet. nodejs/undici is still a separate module independent of node.js core. There is an active discussion happening about whether it will be vendored in but that decision has not been made yet.

Where do the discussion take place?

It's at nodejs/node#38533

lib/fetch/body.js

Refs: #928 (comment)

* fix: request body.body regression Refs: #928 (comment) * fixup * fixup * fixup * fixup * fixup

* fix: implement fetch per spec Also ports node-fetch tests. * fixup: strict null check * fixup: extractBody * fixup: body used * fixup: use instanceof Blob * fixup * fixup * fixup: isBodyReadable * fixup: localURLSOnly * fixup: timingAllow * fixup: timingInfo * fixup: disregard any enqueuing * fixup: strict cmp * fixup: clone * fixup: don't need to copy URL * fix: Response init * fixup: opaqueredirect * fixup: avoid new Response * fixup: abort default err * fixup: url * fixup: don't use body.source when writing request body * fixup * fixup * fixup: fixes from review * fixup: check valid reason phrase * fixup: error messages * fixup: isBuffer * fixup: more error msg * fixup: forbidden methods * fixup: node stream body does not violate spec * fixup: error msgs * fixup * fixup * fixup * fixup * fixup: chrome compat * fixup * fixup: error msgs * fixup * fixup: timingInfo * fixup: comments * fixup: prettier + standard --fix * fixup: bad port + missing cond * fixup: docs * fixup: move fetch to new folder * fixup: Dispatcher.fetch doesn't exist * fixup: link MDN docs * fixup * fixup: node fetch in CI * fixup: terminate on onError * fixup * fixup: transmit request body algorithm * fixup * fixup * fixup * fixup

* fix: request body.body regression Refs: nodejs#928 (comment) * fixup * fixup * fixup * fixup * fixup

* fix: implement fetch per spec Also ports node-fetch tests. * fixup: strict null check * fixup: extractBody * fixup: body used * fixup: use instanceof Blob * fixup * fixup * fixup: isBodyReadable * fixup: localURLSOnly * fixup: timingAllow * fixup: timingInfo * fixup: disregard any enqueuing * fixup: strict cmp * fixup: clone * fixup: don't need to copy URL * fix: Response init * fixup: opaqueredirect * fixup: avoid new Response * fixup: abort default err * fixup: url * fixup: don't use body.source when writing request body * fixup * fixup * fixup: fixes from review * fixup: check valid reason phrase * fixup: error messages * fixup: isBuffer * fixup: more error msg * fixup: forbidden methods * fixup: node stream body does not violate spec * fixup: error msgs * fixup * fixup * fixup * fixup * fixup: chrome compat * fixup * fixup: error msgs * fixup * fixup: timingInfo * fixup: comments * fixup: prettier + standard --fix * fixup: bad port + missing cond * fixup: docs * fixup: move fetch to new folder * fixup: Dispatcher.fetch doesn't exist * fixup: link MDN docs * fixup * fixup: node fetch in CI * fixup: terminate on onError * fixup * fixup: transmit request body algorithm * fixup * fixup * fixup * fixup

* fix: request body.body regression Refs: nodejs#928 (comment) * fixup * fixup * fixup * fixup * fixup

ronag requested a review from mcollina August 5, 2021 06:28

This comment has been minimized.

Sign in to view

ronag force-pushed the node-fetch branch from d59f070 to 3f05e3e Compare August 5, 2021 06:54

This comment has been minimized.

Sign in to view

ronag force-pushed the node-fetch branch from 3f05e3e to 611a562 Compare August 5, 2021 06:59

mcollina reviewed Aug 5, 2021

View reviewed changes

ronag force-pushed the node-fetch branch from 611a562 to d9a0489 Compare August 5, 2021 07:41

ronag force-pushed the node-fetch branch from d9a0489 to 6749e38 Compare August 5, 2021 07:50

ronag force-pushed the node-fetch branch from 871eb47 to 8c198e1 Compare August 5, 2021 07:55

ronag requested review from Ethan-Arrowood and mcollina August 5, 2021 08:13

ronag force-pushed the node-fetch branch 2 times, most recently from 469f55a to 7ec6fbc Compare August 5, 2021 08:44

szmarczak reviewed Aug 5, 2021

View reviewed changes

index.js Outdated Show resolved Hide resolved