Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add community CITGM checks #64

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

richardlau
Copy link
Contributor

Output a warning for packages either not included in the list of community CITGM runs or are in the list but skipped for an in support version of Node.js.

Fixes: #46

Output a warning for packages either not included in the list of
community CITGM runs or are in the list but skipped for an in
support version of Node.js.
@richardlau richardlau requested a review from a team August 25, 2021 15:44
Copy link
Member

@aalykiot aalykiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @richardlau if you have not already can you create a JIRA to add the ability to specify modules for which warnings should not be repoted?

@richardlau richardlau merged commit 7ceeced into nodeshift:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check against community CITGM list
4 participants