Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the service instance endpoint #125

Merged

Conversation

lholmquist
Copy link
Member

fixes #121

@tremes want to give this a try

the below example should do something

'use strict';

const openshiftRestClient = require('openshift-rest-client').OpenshiftClient;

(async function () {
  const client = await openshiftRestClient();

  const sc = await client.apis['servicecatalog.k8s.io'].v1beta1.serviceinstance.get();

  console.log(sc);
})();

@coveralls
Copy link

coveralls commented Apr 23, 2019

Pull Request Test Coverage Report for Build 374

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 373: 0.0%
Covered Lines: 43
Relevant Lines: 43

💛 - Coveralls

@tremes
Copy link
Contributor

tremes commented Apr 24, 2019

Works fine for me. Even e.g await client.apis['servicecatalog.k8s.io'].v1beta1.ns("evals11-shared-9ef0").serviceinstance.get(). Thanks Luke.

@lholmquist lholmquist merged commit d0d9374 into nodeshift:master Apr 24, 2019
@lholmquist lholmquist deleted the 121-service-instance-endpoint branch April 24, 2019 12:31
@lholmquist lholmquist removed the review label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't handle serviceinstance resources
3 participants