Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#166 - add optional auth url param to client settings #167

Merged
merged 1 commit into from
Sep 30, 2019
Merged

#166 - add optional auth url param to client settings #167

merged 1 commit into from
Sep 30, 2019

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Sep 24, 2019

No description provided.

@coveralls
Copy link

coveralls commented Sep 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 527

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 508: 0.0%
Covered Lines: 43
Relevant Lines: 43
💛 - Coveralls

@lholmquist lholmquist self-requested a review September 24, 2019 12:47
lholmquist
lholmquist reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add a test for this

lib/basic-auth-request.js Outdated Show resolved Hide resolved
lholmquist
lholmquist approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lholmquist lholmquist merged commit 11df861 into nodeshift:master Sep 30, 2019
@lholmquist lholmquist mentioned this pull request Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremes @coveralls @lholmquist