Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request with undici #322

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Oct 10, 2022

These commit replace request with undici.


Apart from the tests passing, a manual test was performed using:

First login using oc:

$ oc login
You must obtain an API token by visiting https://oauth-openshift.apps.sandbox.x8i5.p1.openshiftapps.com/oauth/token/request
$ oc login --token=<token>
Logged into "https://api.sandbox.x8i5.p1.openshiftapps.com:6443" as "dbevenius" using the token provided.

You have one project on this server: "dbevenius-dev"

Using project "dbevenius-dev".

Then run one of the examples from the README.md:

$ node - <<HERE
const openshiftRestClient = require('./index.js').OpenshiftClient;

openshiftRestClient().then((client) => {
  client.apis['project.openshift.io'].v1.projects.get().then((response) => {
    console.log(response.body);
  });
});
HERE
{
  kind: 'ProjectList',
  apiVersion: 'project.openshift.io/v1',
  metadata: {},
  items: [ { metadata: [Object], spec: [Object], status: [Object] } ]
}

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a6d1f4c on danbev:replace-request-with-undici into 0fa1283 on nodeshift:main.

@lholmquist
Copy link
Member

👀

@lholmquist lholmquist merged commit b4d606b into nodeshift:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants