Skip to content

Commit

Permalink
src: NODE_RELEASE should be node
Browse files Browse the repository at this point in the history
So we remain compatible with Node.js.

PR-URL: #36
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
santigimeno authored and trevnorris committed Dec 7, 2023
1 parent 55a2d6c commit 4576d9a
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
#endif

#ifndef NODE_RELEASE
#define NODE_RELEASE "nsolid"
#define NODE_RELEASE "node"
#endif

#ifndef NODE_TAG
Expand Down
6 changes: 3 additions & 3 deletions test/message/unhandled_promise_trace_warnings.out
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(nsolid:*) UnhandledPromiseRejectionWarning: Error: This was rejected
(node:*) UnhandledPromiseRejectionWarning: Error: This was rejected
at * (*test*message*unhandled_promise_trace_warnings.js:*)
at *
at *
Expand All @@ -9,15 +9,15 @@
at *
at *
at *
(nsolid:*) Error: This was rejected
(node:*) Error: This was rejected
at * (*test*message*unhandled_promise_trace_warnings.js:*)
at *
at *
at *
at *
at *
at *
(nsolid:*) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
(node:*) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
at handledRejection (node:internal/process/promises:*)
at promiseRejectHandler (node:internal/process/promises:*)
at Promise.then *
Expand Down
2 changes: 1 addition & 1 deletion test/message/v8_warning.out
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
(nsolid:*) V8: *v8_warning.js:* Invalid asm.js: Invalid return type
(node:*) V8: *v8_warning.js:* Invalid asm.js: Invalid return type
(Use `* --trace-warnings ...` to show where the warning was created)
2 changes: 1 addition & 1 deletion test/parallel/test-process-redirect-warnings-env.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ const warnpath = path.join(tmpdir.path, 'warnings.txt');
fork(warnmod, { env: { ...process.env, NODE_REDIRECT_WARNINGS: warnpath } })
.on('exit', common.mustCall(() => {
fs.readFile(warnpath, 'utf8', common.mustSucceed((data) => {
assert.match(data, /\(nsolid:\d+\) Warning: a bad practice warning/);
assert.match(data, /\(node:\d+\) Warning: a bad practice warning/);
}));
}));
2 changes: 1 addition & 1 deletion test/parallel/test-process-redirect-warnings.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ const warnpath = path.join(tmpdir.path, 'warnings.txt');
fork(warnmod, { execArgv: [`--redirect-warnings=${warnpath}`] })
.on('exit', common.mustCall(() => {
fs.readFile(warnpath, 'utf8', common.mustSucceed((data) => {
assert.match(data, /\(nsolid:\d+\) Warning: a bad practice warning/);
assert.match(data, /\(node:\d+\) Warning: a bad practice warning/);
}));
}));
2 changes: 1 addition & 1 deletion test/parallel/test-process-release.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ require('../common');
const assert = require('assert');
const versionParts = process.versions.node.split('.');

assert.strictEqual(process.release.name, 'nsolid');
assert.strictEqual(process.release.name, 'node');

// It's expected that future LTS release lines will have additional
// branches in here
Expand Down
2 changes: 1 addition & 1 deletion test/pseudo-tty/test-tty-color-support-warning-2.out
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

(nsolid:*) Warning: The 'NODE_DISABLE_COLORS' env is ignored due to the 'FORCE_COLOR' env being set.
(node:*) Warning: The 'NODE_DISABLE_COLORS' env is ignored due to the 'FORCE_COLOR' env being set.
(Use `* --trace-warnings ...` to show where the warning was created)
2 changes: 1 addition & 1 deletion test/pseudo-tty/test-tty-color-support-warning.out
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

(nsolid:*) Warning: The 'NODE_DISABLE_COLORS' and 'NO_COLOR' env is ignored due to the 'FORCE_COLOR' env being set.
(node:*) Warning: The 'NODE_DISABLE_COLORS' and 'NO_COLOR' env is ignored due to the 'FORCE_COLOR' env being set.
(Use `* --trace-warnings ...` to show where the warning was created)
2 changes: 1 addition & 1 deletion test/pseudo-tty/test-tty-color-support.out
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
(nsolid:*) Warning: The 'NO_COLOR' env is ignored due to the 'FORCE_COLOR' env being set.
(node:*) Warning: The 'NO_COLOR' env is ignored due to the 'FORCE_COLOR' env being set.
(Use `* --trace-warnings ...` to show where the warning was created)

0 comments on commit 4576d9a

Please sign in to comment.