-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MongoMemoryReplSet class, tests, and docs #81
Conversation
Newly provided definitions: * get-port * getos New definition via `flow-typed install`: * rimraf
…or code style by default.
Impressive changes! Also, I saw your pain with flow typescript and vscode ))) 4 days ago I did the same thing. Historically my open-source libs started from graphql-compose. It takes Anyway, I feel that both TypeScript and Flowtype are amazing tools. And we as lib authors should support both of them as close to code as possible. Flow is younger than Typescript, but if there was no such competition between them, we would have had something much worse than now. |
We should move fast, I see that your code is very clear and stable. Real testing I will do tomorrow at work. And if I'll found any problems then make them via small additional fixes ;) Thanks for the AMAZING work!!!! |
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
As to supporting both type systems I think that if I bother to do such a thing in my future projects I will write the code in TypeScript, which has better typings available today, and then make an equivalent Flowtype interface definition file, which would be easily adapted from the It would be awesome if the transformation could be handled automatically but when I tried to use |
I have implemented the
MongoMemoryReplSet
feature roughly as I described in #79. Please review and let me know if there is anything you feel needs to be changed. This, in combination with my previously merged PR should complete #74.On a side note, flow typings still really seem to be much less robust/complete than what is available for TypeScript. I would have expected them to have caught up by now. Glad I use TypeScript normally, the more accurate code insight/completion it provides is amazing.