Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue downloading mongo binaries with Nexus set as MONGOMS_DOWNLOAD_MIRROR #865

Closed
SimoneDutto opened this issue Apr 19, 2024 · 8 comments · Fixed by nodeshift/mern-workshop#212 · May be fixed by anand-py/crm_application_backend#4
Labels
enhancement released on @beta released Pull Request released | Issue is fixed

Comments

@SimoneDutto
Copy link

Hi, I am having issue downloading mongo-binaries using a Nexus as the mirror.

After having spent some time debugging, I found the root cause of the problem to be that my nexus is not setting the content-length header.
Manually removing the check at this line solved my issue.

I am willing to help solving the issue and creating a PR if needed.

@hasezoey
Copy link
Member

if you want you can make a PR for that.

@SimoneDutto
Copy link
Author

is it enough to remove the check or do you want something like a config variable?

@hasezoey
Copy link
Member

well that check is there to ensure that the progress does not have "10MB/0MB" or something, in addition also i guess it is a slight security thing to not download unknown length for a unknown amount of time (though we dont enforce that)

i can also put out a quick fix, if you want

@SimoneDutto
Copy link
Author

You are right about the security thing, but my nexus does not set this header. I don't see a way around it, besides removing the check if an env var is set. In a similar fashion to line

Copy link

🎉 This issue has been resolved in version 9.2.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hasezoey
Copy link
Member

a fix has been made in f3f7764, if you enable config option DOWNLOAD_IGNORE_MISSING_HEADER, please test this works for you.

@SimoneDutto
Copy link
Author

That solved the issue! Thanks a lot.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment