Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: Implement diagnostics #1584

Closed
Tracked by #1558
phated opened this issue Jun 6, 2023 · 0 comments · Fixed by #1676
Closed
Tracked by #1558

LSP: Implement diagnostics #1584

phated opened this issue Jun 6, 2023 · 0 comments · Fixed by #1676
Assignees
Labels
enhancement New feature or request lsp Language Server Protocol

Comments

@phated
Copy link
Contributor

phated commented Jun 6, 2023

Problem

The LSP should implement diagnostics (compilation & type checking error messages/warnings/etc) following https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_diagnostic

This could be implemented as "publish" (via the server) or "pull" via the client, see https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_publishDiagnostics and https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_pullDiagnostics respectively.

We likely also want to implement workspace diagnostics as per https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_diagnostic (see "Implementation Considerations" at the bottom)

Happy Case

Users should receive feedback on the state of the code they write via an LSP client. This can include red or yellow underlines for errors and warnings or other feedback they need.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@phated phated added the enhancement New feature or request label Jun 6, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 6, 2023
@phated phated added the lsp Language Server Protocol label Jun 6, 2023
@phated phated self-assigned this Jun 12, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lsp Language Server Protocol
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant