Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dom check panics #1664

Closed
joss-aztec opened this issue Jun 13, 2023 · 2 comments · Fixed by #1759
Closed

dom check panics #1664

joss-aztec opened this issue Jun 13, 2023 · 2 comments · Fixed by #1759
Labels
bug Something isn't working refactor ssa

Comments

@joss-aztec
Copy link
Contributor

Aim

Test named regression should compile.

Expected Behavior

^

Bug

Panic:

The application panicked (crashed).
Message:  assertion failed: dom_tree.dominates(branch_beginning, predecessor)
Location: crates/noirc_evaluator/src/ssa_refactor/opt/flatten_cfg.rs:275

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@joss-aztec joss-aztec added bug Something isn't working refactor ssa labels Jun 13, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 13, 2023
@joss-aztec joss-aztec mentioned this issue Jun 19, 2023
Merged
5 tasks
@joss-aztec
Copy link
Contributor Author

Affects test named ec_baby_jubjub

@joss-aztec
Copy link
Contributor Author

In case of regression, failed assertion is for checking block 2 dominates block 1 in following graph:
Screenshot 2023-06-19 at 16 51 29

@joss-aztec joss-aztec mentioned this issue Jun 20, 2023
Merged
5 tasks
@kevaundray kevaundray added the e2e label Jun 20, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working refactor ssa
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ssa refactor): recursive branch analysis noir-lang/noir
2 participants
@kevaundray @joss-aztec