Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): truncate when simplifying constant casts #1714

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix(ssa refactor): truncate when simplifying constant casts #1714

merged 2 commits into from
Jun 15, 2023

Conversation

joss-aztec
Copy link
Contributor

Description

Problem*

The behaviour of cast was inconsistent between ACIR gen and SSA instruction simplicifcation.

Summary*

  • Simplification of cast now only simplifies a constant if both the src and dst are unsigned integers
  • The simplification of such constants now truncates by the integer modulus

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@joss-aztec joss-aztec requested a review from jfecher June 15, 2023 15:46
jfecher
jfecher previously approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfecher jfecher added this pull request to the merge queue Jun 15, 2023
Merged via the queue into master with commit a2108d7 Jun 15, 2023
@jfecher jfecher deleted the joss/fix-cast-simplify branch June 15, 2023 17:12
This was referenced Jun 15, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joss-aztec @jfecher