Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): Speedup find-branch-ends #1786

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix(ssa refactor): Speedup find-branch-ends #1786

merged 2 commits into from
Jun 21, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 21, 2023 •
edited
Loading

Description

Problem*

The find_branch_ends function was recurring forever on the eddsa and sha2_byte tests so I've replaced it with a different algorithm that is O(N) and never revisits a block.

This is related to #1750 but is not related to the acir-gen issue that was taking forever there.

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested review from ludamad and kevaundray June 21, 2023 20:52
ludamad
ludamad approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevaundray kevaundray enabled auto-merge June 21, 2023 21:31
@kevaundray kevaundray added this pull request to the merge queue Jun 21, 2023
Merged via the queue into master with commit 861e42c Jun 21, 2023
@kevaundray kevaundray deleted the jf/speedup-branch-ends branch June 21, 2023 23:50
This was referenced Jun 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfecher @ludamad @kevaundray